Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KongCertificate reconciler #643

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Sep 25, 2024

What this PR does / why we need it:

Add KongCertificate reconciler

Which issue this PR fixes

Fixes #581

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@tao12345666333 tao12345666333 self-assigned this Sep 25, 2024
@tao12345666333 tao12345666333 force-pushed the feat/KongCertificate branch 3 times, most recently from 97fb9f9 to 34e93b4 Compare September 25, 2024 11:39
@tao12345666333 tao12345666333 added this to the KGO v1.4.x milestone Sep 25, 2024
@tao12345666333 tao12345666333 force-pushed the feat/KongCertificate branch 2 times, most recently from 8c7a94e to 3c3dfe4 Compare September 25, 2024 12:45
@tao12345666333 tao12345666333 marked this pull request as ready for review September 25, 2024 12:47
@tao12345666333 tao12345666333 requested a review from a team as a code owner September 25, 2024 12:47
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Just one minor nit about falling back to creation when upsert returns not found error.

controller/konnect/ops/ops_kongcertificate.go Show resolved Hide resolved
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 merged commit ee76d6d into main Sep 26, 2024
21 checks passed
@tao12345666333 tao12345666333 deleted the feat/KongCertificate branch September 26, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Konnect entities: Certificate
3 participants