Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(konnect): add KongKey reconciler #646

Merged
merged 3 commits into from
Sep 26, 2024
Merged

feat(konnect): add KongKey reconciler #646

merged 3 commits into from
Sep 26, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Sep 25, 2024

What this PR does / why we need it:

Adds KongKey reconciler. KongKeySet references are to be handled in a separate PR.

Which issue this PR fixes

Fixes #584.

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@czeslavo czeslavo self-assigned this Sep 25, 2024
@czeslavo czeslavo added this to the KGO v1.4.x milestone Sep 25, 2024
@czeslavo czeslavo marked this pull request as ready for review September 25, 2024 15:55
@czeslavo czeslavo requested a review from a team as a code owner September 25, 2024 15:55
@czeslavo czeslavo force-pushed the feat/kongkey branch 3 times, most recently from 8f0f594 to fa3ca42 Compare September 26, 2024 08:26
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 minor nit.

controller/konnect/ops/ops_kongkey.go Outdated Show resolved Hide resolved
@czeslavo czeslavo requested a review from pmalek September 26, 2024 08:35
@czeslavo czeslavo enabled auto-merge (squash) September 26, 2024 08:37
@czeslavo czeslavo merged commit c7bb380 into main Sep 26, 2024
21 checks passed
@czeslavo czeslavo deleted the feat/kongkey branch September 26, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Konnect entities: Key
2 participants