Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(konnect): allow binding KongConsumer in KongPluginBinding #652

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Sep 26, 2024

What this PR does / why we need it:

Requires #651

Which issue this PR fixes

Fixes #526

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek added this to the KGO v1.4.x milestone Sep 26, 2024
@pmalek pmalek self-assigned this Sep 26, 2024
@pmalek pmalek force-pushed the kongplugin-consumer branch 3 times, most recently from e0876f5 to 9314676 Compare September 26, 2024 10:43
@pmalek pmalek force-pushed the kongplugin-consumer branch from 9314676 to 61fbbf0 Compare September 26, 2024 12:01
@pmalek pmalek marked this pull request as ready for review September 26, 2024 12:03
@pmalek pmalek requested a review from a team as a code owner September 26, 2024 12:03
@pmalek pmalek enabled auto-merge (squash) September 26, 2024 12:03
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits.

pmalek and others added 2 commits September 26, 2024 14:29
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
@pmalek pmalek merged commit 3d3dbf6 into main Sep 26, 2024
21 checks passed
@pmalek pmalek deleted the kongplugin-consumer branch September 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Konnect entities: allow KongConsumer to be targeted by a KongPluginBinding
2 participants