feat(konnect): add finalizer handling for unmanaged KongPluginBindings for KongConsumer and KongConsumerGroup
#704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
changed the title
KongConsumer and KongConsumerGroup
pmalek
force-pushed
the
kongpluginbinding-cleanup-finalizer
branch
2 times, most recently
from
8c01a75
to
adccdaa
Compare
pmalek
force-pushed
the
kongpluginbinding-cleanup-finalizer
branch
from
adccdaa
to
3c11bab
Compare
czeslavo
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds handling of
gateway.konghq.com/cleanup-plugin-bindingfinalizer for unmanaged (created by users)KongPluginBindings targetingKongConsumerandKongConsumerGroup.This PR also does some refactoring in
controller/konnect/reconciler_generic_pluginbindingfinalizer.goto decrease code duplication.Which issue this PR fixes
Fixes #
Special notes for your reviewer:
Follow up on #683 and #611
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes