Skip to content

Commit

Permalink
fix(runner): consider event for failure detection
Browse files Browse the repository at this point in the history
To detect failures we were relying on Busted's exit status. This commit
changes the logic to use the events emitted by Busted to detect failures
instead.
  • Loading branch information
samugi committed Jan 3, 2024
1 parent 575cede commit 952562e
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 3 deletions.
10 changes: 9 additions & 1 deletion dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

10 changes: 9 additions & 1 deletion src/runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,18 @@ const runner = async (

const runTest = async (test) => {
const { suite, exclude_tags, environment, filename } = test
let failed = false
const listener = await bustedEventListener(
bustedEventPath,
({ event, args }) => {
switch (event) {
case 'failure':
case 'failure:it':
case 'error':
case 'error:it':
failed = true
break

case 'file:end': {
const { duration } = args[0]
appendToFile(
Expand Down Expand Up @@ -91,7 +99,7 @@ const runner = async (

await saveTestResult(test, exitStatus, output)

if (exitStatus !== 0) {
if (exitStatus !== 0 || failed) {
console.error(`\nTest failed with exit status: ${exitStatus} ($output)`)
return false
}
Expand Down

0 comments on commit 952562e

Please sign in to comment.