fix: fixed req-validator config generation when both body and param schema are empty. #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chema are empty. In the above case, we wish to skip the config generation. Due to improper checking of the generated parameter schema, it was not getting assigned nil, as it is supposed to. This change corrects the check to length based-checking and improved the test to validate the same.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage 69.23% 69.23%
=======================================
Files 24 24
Lines 3361 3361
=======================================
Hits 2327 2327
Misses 862 862
Partials 172 172 ☔ View full report in Codecov by Sentry. |
Tieske
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the above case, we wish to skip the config
generation. Due to improper checking of the
generated parameter schema, it was not
getting assigned nil, as it is supposed to.
This change corrects the check to length
based-checking and improved the test to
validate the same.
For: #241