tests: fix plugin defaulting tests

Kong · Apr 3, 2024 · a563c04 · a563c04
1 parent 95e9e2a
commit a563c04
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/kong/plugin_service_test.go b/kong/plugin_service_test.go
@@ -564,7 +564,7 @@ func TestFillPluginDefaults(T *testing.T) {
 	}{
 		{
 			name:    "no config no protocols",
-			version: ">=3.7.0",
+			version: ">=3.6.0",
 			plugin: &Plugin{
 				Name:  String("basic-auth"),
 				RunOn: String("test"),
@@ -575,15 +575,17 @@ func TestFillPluginDefaults(T *testing.T) {
 				Config: Configuration{
 					"anonymous":        nil,
 					"hide_credentials": false,
-					"realm":            "service",
+					// NOTE: realm has been introduced in 3.6 basic auth schema
+					// https://docs.konghq.com/hub/kong-inc/basic-auth/changelog/#kong-gateway-36x
+					"realm": "service",
 				},
 				Protocols: []*string{String("grpc"), String("grpcs"), String("http"), String("https")},
 				Enabled:   Bool(true),
 			},
 		},
 		{
 			name:    "no config no protocols",
-			version: "<3.7.0",
+			version: "<3.6.0",
 			plugin: &Plugin{
 				Name:  String("basic-auth"),
 				RunOn: String("test"),
@@ -601,7 +603,7 @@ func TestFillPluginDefaults(T *testing.T) {
 		},
 		{
 			name:    "partial config no protocols",
-			version: ">=3.7.0",
+			version: ">=3.6.0",
 			plugin: &Plugin{
 				Name: String("basic-auth"),
 				Consumer: &Consumer{
@@ -619,15 +621,17 @@ func TestFillPluginDefaults(T *testing.T) {
 				Config: Configuration{
 					"anonymous":        nil,
 					"hide_credentials": true,
-					"realm":            "service",
+					// NOTE: realm has been introduced in 3.6 basic auth schema
+					// https://docs.konghq.com/hub/kong-inc/basic-auth/changelog/#kong-gateway-36x
+					"realm": "service",
 				},
 				Protocols: []*string{String("grpc"), String("grpcs"), String("http"), String("https")},
 				Enabled:   Bool(true),
 			},
 		},
 		{
 			name:    "partial config no protocols",
-			version: "<3.7.0",
+			version: "<3.6.0",
 			plugin: &Plugin{
 				Name: String("basic-auth"),
 				Consumer: &Consumer{