Skip to content

Commit

Permalink
[smoke] fixes extensions
Browse files Browse the repository at this point in the history
  • Loading branch information
dimitropoulos committed May 17, 2021
1 parent 9a9b5dd commit 55ea7e3
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/insomnia-smoke-test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ npm run test:smoke:cli # Run CLI tests
npm run test:smoke:build # Run Insomnia tests
```

Sometimes, you might need to run tests against a _packaged_ application. A packaged application is the final artifact which bundles all of the various resources together, and is created for distribution in the form of a `.dmg` or `.exe`, etc. Packaging takes longer to do and is only required for edge cases (such as a [plugin installation](https://github.com/Kong/insomnia/blob/357b8f05f89fd5c07a75d8418670abe37b2882dc/packages/insomnia-smoke-test/designer/app.test.js#L36)), so we typically run tests against a build. To run packaged tests, from the root:
Sometimes, you might need to run tests against a _packaged_ application. A packaged application is the final artifact which bundles all of the various resources together, and is created for distribution in the form of a `.dmg` or `.exe`, etc. Packaging takes longer to do and is only required for edge cases (such as a <!-- TODO(TSCONVERSION) update this link -->[plugin installation](https://github.com/Kong/insomnia/blob/357b8f05f89fd5c07a75d8418670abe37b2882dc/packages/insomnia-smoke-test/designer/app.test.js#L36)), so we typically run tests against a build. To run packaged tests, from the root:

``` sh
npm run app-package:smoke # Package Insomnia
Expand Down
44 changes: 44 additions & 0 deletions packages/insomnia-smoke-test/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/insomnia-smoke-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"spectron:build": "cross-env BUNDLE=build xvfb-maybe jest --detectOpenHandles --testPathPattern core",
"spectron:package": "cross-env BUNDLE=package xvfb-maybe jest --detectOpenHandles --testPathPattern core",
"cli": "jest --detectOpenHandles --testPathPattern cli",
"serve": "node server/index.js",
"serve": "ts-node src/server/index.ts",
"with-mock": "concurrently --names server,app --success first --kill-others \"npm run serve\"",
"test:cli": "npm run with-mock \"npm run cli\"",
"test:build": "npm run with-mock \"npm run spectron:build\"",
Expand All @@ -46,6 +46,7 @@
"mkdirp": "^1.0.4",
"spectron": "^11.1.0",
"spectron-keys": "0.0.1",
"ts-node": "^9.1.1",
"xvfb-maybe": "^0.2.1"
}
}
2 changes: 1 addition & 1 deletion packages/insomnia-smoke-test/src/server/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import express from 'express';
import basicAuth from 'express-basic-auth';
import { basicAuthCreds } from '../fixtures/constants.js';
import { basicAuthCreds } from '../fixtures/constants';

const app = express();
const basicAuthRouter = express.Router();
Expand Down

0 comments on commit 55ea7e3

Please sign in to comment.