Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot clone a git repository that is hosted on-premise #5967

Closed
1 task done
msbmw opened this issue May 16, 2023 · 2 comments · Fixed by #5968
Closed
1 task done

Cannot clone a git repository that is hosted on-premise #5967

msbmw opened this issue May 16, 2023 · 2 comments · Fixed by #5968
Labels
B-bug Bug: general classification S-unverified Status: Unverified by maintainer

Comments

@msbmw
Copy link

msbmw commented May 16, 2023

Expected Behavior

I want to be able to clone a git repository, that is hosted on-premise, e.g. https://foo.bar.com/bitbucket/scm/org/repo.git.

Actual Behavior

If I try to clone this repository in Insomnia, I get the following error message:

Screenshot 2023-05-16 at 12 47 09

#5954 uses hosted-git-info for git url parsing, however it does not support on-premise hosted git repositories, see npm/hosted-git-info#11

the following code will result in an empty string when trying to parse an on-premise git repository:

 repoSettingsPatch.uri = fromUrl(repoSettingsPatch.uri)?.https() || '';

see https://github.com/Kong/insomnia/blob/develop/packages/insomnia/src/ui/routes/git-actions.tsx#L327

Reproduction Steps

  1. Open the git clone UI:
Screenshot 2023-05-16 at 12 53 57
  1. enter a git repo url that is not on one of the hosts that is supported by hosted-git-info

  2. fill in the other fields

Screenshot 2023-05-16 at 12 56 42
  1. click on "Clone"

Is there an existing issue for this?

Additional Information

No response

Insomnia Version

2023.2.1

What operating system are you using?

macOS

Operating System Version

macOS 13.3.1

Installation method

installed via brew

Last Known Working Insomnia version

No response

@msbmw msbmw added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels May 16, 2023
@filfreire
Copy link
Member

@msbmw thanks for reporting this, we'll have the fix for it soon out. In the meantime please feel free to use the previous version, 2023.2.0 instead of 2023.2.1

@filfreire
Copy link
Member

@msbmw fix is merged, will go out in upcoming 2023.2.2 patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification S-unverified Status: Unverified by maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants