Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INS-2497: prevent git sync parse failure #5954

Merged
merged 3 commits into from
May 15, 2023
Merged

INS-2497: prevent git sync parse failure #5954

merged 3 commits into from
May 15, 2023

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented May 10, 2023 •
edited
Loading

Closes INS-2497

changelog(Improvements): Added better parsing of Git URLs

@filfreire filfreire marked this pull request as ready for review May 10, 2023 16:23
@filfreire filfreire requested review from jackkav, gatzjames and a team May 10, 2023 16:23
gatzjames
gatzjames approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

jackkav
jackkav approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@jackkav jackkav added this pull request to the merge queue May 15, 2023
Merged via the queue into Kong:develop with commit 28f6e18 May 15, 2023
@msbmw msbmw mentioned this pull request May 16, 2023
Closed
1 task
@filfreire filfreire deleted the feature/ins-2497-bug-prevent-parse-url-failure-on-git branch May 18, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatzjames gatzjames gatzjames approved these changes

@jackkav jackkav jackkav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filfreire @jackkav @gatzjames