Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning on import #8350

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Feb 10, 2025

image

Ref: INS-4963

Any suggestions on wording?

@jackkav jackkav marked this pull request as ready for review February 11, 2025 13:45
@jackkav jackkav requested review from godfrzero, gatzjames and a team February 11, 2025 14:02
@filfreire
Copy link
Member

@jackkav LGTM.

I would recommend adding a warning icon.

We should also add this warning (slightly different) on the plugin install menu.

@jackkav jackkav force-pushed the warn-on-import-and-add-plugin branch from 8230aba to 5b173d1 Compare February 12, 2025 13:05
@jackkav jackkav merged commit 54915fb into Kong:develop Feb 12, 2025
8 checks passed
@jackkav jackkav deleted the warn-on-import-and-add-plugin branch February 12, 2025 13:06
pavkout pushed a commit to pavkout/insomnia that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants