This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(*) timestamps and annotations #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zipkin expects timestamps to be integers. We were sending floats instead. This commit changes them to integers using math.floor.
Zipkin expects the `value` field of an annotation to be mandatory. We were using `event` instead. This changes `event` to `value`.
According to https://zipkin.io/zipkin-api: > Usually a short tag indicating an event, like “error” > > While possible to add larger data, such as garbage collection details, low cardinality event names both keep the size of spans down and also are easy to search against. Given that the previous versions of annotations didn't work with zipkin anyway (because they had no value field) these new anotations will also follow this directive. Instead of "kong.access.start" the annotation value will be "kas". "kong.header_filter.finish" becomes "khf". And so on.
gszr
changed the title
- Use an actual Zipkin server in tests - Remove dependency on lua-http and cqueues, by using Kong's existing helper HTTP client and Zipkin server
gszr
force-pushed
the
fix/timestamps-and-annotations
branch
3 times, most recently
from
e0c7108 to
b0442c2
Compare
gszr
reviewed
Dec 20, 2019
| end) | ||
|
|
||
| it("propagates b3 headers on routed request", function() |
There was a problem hiding this comment.
This case was removed as the tests now leverage the b3 headers by default.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several changes:
eventkey was renamed tovalue)kasinstead ofkong.access.start, for example).This PR also includes changes in the test suite which run a proper Zipkin server instead of a mocked one.