Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) migrate our nightlies from master-nightly-alpine #300

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

hutchic
Copy link
Contributor

@hutchic hutchic commented Jul 11, 2022

We now build docker containers that are simply named after the branch so kong/kong-gateway-internal:master

@Tieske
Copy link
Member

Tieske commented Jul 11, 2022

Since alpine is not considered production ready, I was actually thinking of switching to another base image. If we remove the base image name, how will we be able to switch later?

@hutchic
Copy link
Contributor Author

hutchic commented Jul 18, 2022

as of 3.x our alpine debian-slim and ubi-slim are all slimmed images. Whatever we make the default it will be a slim image that can be considered production and downstream projects should be safe to utilise that image

pongo.sh Outdated Show resolved Hide resolved
@Tieske
Copy link
Member

Tieske commented Jul 18, 2022

That change doesn't seem to work: https://app.travis-ci.com/github/Kong/kong-pongo/jobs/576951914#L281

@Tieske
Copy link
Member

Tieske commented Jul 18, 2022

The previous commit failed on the missing commit-id (in the labels); https://app.travis-ci.com/github/Kong/kong-pongo/jobs/576308638#L295

@hutchic
Copy link
Contributor Author

hutchic commented Jul 18, 2022

Right sorry my bad -- master-alpine won't exist until after https://github.com/Kong/kong-ee/pull/3466 merges

@Tieske
Copy link
Member

Tieske commented Jul 21, 2022

just verified, the failing test now works (cancelled the others because of duration, hence the reported failure still here)

@Tieske Tieske changed the title chore(ci): migrate our nightlies from master-nightly-alpine chore(ci) migrate our nightlies from master-nightly-alpine Jul 21, 2022
@Tieske Tieske merged commit 1034904 into master Jul 21, 2022
@Tieske Tieske deleted the chore/migrate-off-nightly-alpine branch July 21, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants