Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) some tweaks to burn less cpu cycles #339

Merged
merged 2 commits into from
Oct 22, 2022
Merged

chore(ci) some tweaks to burn less cpu cycles #339

merged 2 commits into from
Oct 22, 2022

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Oct 20, 2022

No description provided.

@Tieske
Copy link
Member Author

Tieske commented Oct 20, 2022

seems to fail on this again: actions/checkout#23

Base automatically changed from pongo2 to master October 20, 2022 09:40
@curiositycasualty
Copy link
Contributor

So this burns less CPU.. more intelligently managing the cancellation of related builds when one of them fails?
:shipit: if it works.

@Tieske
Copy link
Member Author

Tieske commented Oct 22, 2022

@curiositycasualty yes, some hints by @wheelerlaw ;

  • better cancellation, so pushing twice in a row to the same branch/PR will cancel the first job
  • running on pull_requests, and "on push" only if to master to prevent the typical dual jobs, though this works mostly for shortlived branches.

In this case, the push and pull_request are in different workflows because on the PR I needed to disable one test, see 2nd commit and the internal slack discussion https://kongstrong.slack.com/archives/C027PKSNBC5/p1666268700904629?thread_ts=1666258977.473739&cid=C027PKSNBC5

@Tieske Tieske merged commit edb2e5d into master Oct 22, 2022
@Tieske Tieske deleted the ci-tweaks branch October 22, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants