Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(0.13_0.14) test ssl cert & snis migration #5

Closed
wants to merge 1 commit into from
Closed

tests(0.13_0.14) test ssl cert & snis migration #5

wants to merge 1 commit into from

Conversation

kikito
Copy link
Member

@kikito kikito commented Apr 10, 2018 •
edited
Loading 

./test.sh -b kong:0.12.1 -t kong-private:certs-2-db upgrade_paths/0.13_0.14
./test.sh -b kong:0.12.1 -d cassandra -t kong-private:certs-2-db upgrade_paths/0.13_0.14

@kikito kikito mentioned this pull request Apr 11, 2018
Merged
@kikito kikito force-pushed the test/cassandra-target-index branch from 46bd91c to bf32fd5 Compare April 12, 2018 17:30
bungle
bungle reviewed Apr 18, 2018
View reviewed changes
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some naming issues(?).

upgrade_paths/0.13_0.14/before/001-ssl-certificates.json
[ 201 ]
],

[ "cert_3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be cert_2?

upgrade_paths/0.13_0.14/before/001-ssl-certificates.json Outdated
[ 201 ]
],

[ "Attach a server name to cert_2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above says cert_3 and here it reads cert_2.

@kikito kikito force-pushed the test/cassandra-target-index branch from bf32fd5 to ac41443 Compare April 19, 2018 16:29
@hishamhm
Copy link
Contributor

hishamhm commented Aug 7, 2019

This is pretty old and refers to no-longer-supported versions. Closing it!

@hishamhm hishamhm closed this Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kikito @hishamhm @bungle