tests(clustering/rpc): fix ee tests for inc sync (#10539)

* tests(rbac): fix 01-rbac/01-rbac_spec.lua (#10463)

* db(dao/workspaces): check kong.conf in select_by_name

* fix 01-rbac/01-rbac_spec.lua

* tests(keyring): pagesize must not be less than 2 (#10462)

* (keyring): pagesize must not be less than 2

* comments

* math.max

* fix(*): remove hardcoded size 1000 from :each interface call (#10480)

* set ws_id nil in tests (#10488)

* fix(incremental sync): fix bug that CP generates entity without expanding foreigns (#10526)

* fix(incremental sync): fix bug that CP generates entity without expanding foreigns

* added XXX EE only

* chore: fallback workspace (#10469)

* remove field_ws_id

* Revert "remove field_ws_id"

This reverts commit 880f5dac107364c7df9800b910631ce1c94451b2.

---------

Co-authored-by: Xiaochen Wang <wangxiaochen0@gmail.com>

kong/db/declarative/export.lua

@@ -409,7 +409,8 @@ end
 
 
 local function export_config_sync()
-  return export_from_db_impl(sync_emitter.new(), false, false, true)
+  -- XXX EE: has extra parameter @skip_ttl
+  return export_from_db_impl(sync_emitter.new(), false, false, false, true)
 end
 
 

kong/db/declarative/import.lua

@@ -439,10 +439,17 @@ end
 --     _transform: true,
 --   }
 local function load_into_cache(entities, meta, hash)
+  meta = meta or {}
+
   local default_workspace_id = assert(find_ws(entities, "default"))
   local should_transform = meta._transform == nil and true or meta._transform
 
+  local fallback_workspace = meta._workspace  -- XXX EE
+                             and find_ws(entities, meta._workspace)
+                             or  default_workspace_id
+
   assert(type(default_workspace_id) == "string")
+  assert(type(fallback_workspace) == "string")
 
   -- set it for insert_entity_for_txn()
   kong.default_workspace = default_workspace_id
@@ -470,7 +477,7 @@ local function load_into_cache(entities, meta, hash)
 
     for _, item in pairs(items) do
       if not schema.workspaceable or item.ws_id == null or item.ws_id == nil then
-        item.ws_id = default_workspace_id
+        item.ws_id = fallback_workspace     -- XXX EE
       end
 
       assert(type(item.ws_id) == "string")

kong/enterprise_edition/counters/sales/init.lua

@@ -195,7 +195,8 @@ local function get_plugins_count()
     ["kafka-upstream"] = 0,
   }
 
-  for plugin, err in kong.db.plugins:each(1000, GLOBAL_QUERY_OPTS) do
+  -- like each(page_size,)
+  for plugin, err in kong.db.plugins:each(nil, GLOBAL_QUERY_OPTS) do
     if err then
       kong.log.err("failed to list plugins: ", err)
       return nil

kong/enterprise_edition/tls/plugins/sni_filter.lua

@@ -244,7 +244,7 @@ local function each_enabled_plugin(entity, plugin_name)
     }
   }
 
-  local iter = entity:each(1000, options)
+  local iter = entity:each(nil, options)  -- like each(page_size,)
   local function iterator()
     local element, err = iter()
     if err then return nil, err end

kong/keyring/strategies/cluster.lua

@@ -178,7 +178,7 @@ function _M.init(config)
 
   load_envelope_keys(config)
 
-  local r, err = kong.db.keyring_meta:each(1)
+  local r, err = kong.db.keyring_meta:each()
   if err then
     error(err)
   end

kong/plugins/acme/api.lua

@@ -23,7 +23,7 @@ local ngx_timer_at = ngx.timer.at
 local ngx_re_match = ngx.re.match
 
 local function find_plugin()
-  for plugin, err in kong.db.plugins:each(1000) do
+  for plugin, err in kong.db.plugins:each() do  -- like each(page_size)
     if err then
       return nil, err
     end

kong/plugins/ai-semantic-cache/api.lua

@@ -17,7 +17,7 @@ local SEMANTIC_CACHE_NAMESPACE_PREFIX = "kong_semantic_cache:"
 
 
 local function each_by_name(entity, name)
-  local iter = entity:each(1000)
+  local iter = entity:each()  -- like each(page_size)
   local function iterator()
     local element, err = iter()
     if err then return nil, err end

kong/plugins/degraphql/handler.lua

@@ -70,7 +70,7 @@ function DeGraphQLHandler:update_router(force)
 
   local routers = {}
 
-  for route, err in kong.db.degraphql_routes:each(1000) do
+  for route, err in kong.db.degraphql_routes:each() do  -- like each(page_size)
     if err then
       kong.log.err("Degraphql plugin could not load routes: ", err)
       -- Break when error and try again on the next update_router

kong/plugins/graphql-proxy-cache-advanced/api.lua

@@ -22,7 +22,7 @@ end
 
 
 local function each_by_name(entity, name)
-  local iter = entity:each(1000)
+  local iter = entity:each()  -- like each(page_size)
   local function iterator()
     local element, err = iter()
     if err then return nil, err end

kong/plugins/proxy-cache-advanced/api.lua

@@ -22,7 +22,7 @@ end
 
 
 local function each_by_name(entity, name)
-  local iter = entity:each(1000)
+  local iter = entity:each()  -- like each(page_size)
   local function iterator()
     local element, err = iter()
     if err then return nil, err end

spec-ee/02-integration/01-rbac/01-rbac_spec.lua

@@ -673,7 +673,9 @@ for _, strategy in spec_helpers.each_strategy() do
     end)
     describe("check_cascade", function()
       local entities
+      local old_conf
       setup(function()
+        old_conf = kong.configuration
         kong.configuration= {
           rbac = "both",
         }
@@ -703,7 +705,7 @@ for _, strategy in spec_helpers.each_strategy() do
         }
       end)
       teardown(function()
-        kong.configuration = nil
+        kong.configuration = old_conf
       end)
 
       it("all entities allowed", function()

spec/02-integration/04-admin_api/15-off_spec.lua

@@ -951,6 +951,7 @@ describe("Admin API #off", function()
         local config = assert(lyaml.load(json.config))
         config.workspaces[1].id = "<uuid>" -- see below
         config.workspaces[1].created_at = 12345 -- see below
+        config.workspaces[1].ws_id = nil -- see below
         config.consumers[1].ws_id = "<uuid>" -- see below
         assert:set_parameter("TableFormatLevel", -1)
         assert.same({