fix(tracing): patch dns query function earlier #11996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dns query lazy patch was only effective for cosockets, not for the upstream dns queries, because the patch happened too late when the `toip` function had already been cached in some modules (i.e. balancer) This change moves the patch to `globalpatches.lua` so that dns spans are correctly generated both for cosocket and upstream dns queries.
samugi
force-pushed
the
fix/tracing-dns-instrum
branch
from
269c013 to
2bf03c5
Compare
samugi
changed the title
2 tasks
dndx
previously approved these changes
Nov 14, 2023
gszr
approved these changes
Nov 14, 2023
3 tasks
samugi
added a commit
that referenced
this pull request
Nov 14, 2023
* add test that covers a scenario that was missing from #11996 where a span is created for the upstream dns query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The dns query lazy patch was only effective for cosockets, not for the upstream dns queries, because the patch happened too late when the
toipfunction had already been cached in some modules (i.e. balancer)This change moves the patch to
globalpatches.luaso that dns spans are correctly generated both for cosocket and upstream dns queries.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
Issue reference
KAG-3057