Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): error when DNS query fails #11935

Merged
merged 3 commits into from
Nov 14, 2023
Merged

fix(tracing): error when DNS query fails #11935

merged 3 commits into from
Nov 14, 2023

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Nov 7, 2023 •
edited by Madi-Ji
Loading

PLEASE MERGE AFTER #11996

Summary

The patching function assumes the query never fails and that's not true.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md

Issue reference

Fix FTI-5544

@StarlightIbuki StarlightIbuki marked this pull request as draft November 7, 2023 07:20
@StarlightIbuki StarlightIbuki force-pushed the fix/dns-tracing-err-hdl branch from 79c7381 to fd56571 Compare November 14, 2023 02:54
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 14, 2023
@StarlightIbuki StarlightIbuki changed the base branch from master to fix/tracing-dns-instrum November 14, 2023 02:54
@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 14, 2023
@StarlightIbuki StarlightIbuki marked this pull request as ready for review November 14, 2023 03:13
Base automatically changed from fix/tracing-dns-instrum to master November 14, 2023 15:18
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 14, 2023
@gszr gszr force-pushed the fix/dns-tracing-err-hdl branch from c34666f to ae805cc Compare November 14, 2023 15:28
@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 14, 2023
@gszr gszr merged commit 4d1fbba into master Nov 14, 2023
@gszr gszr deleted the fix/dns-tracing-err-hdl branch November 14, 2023 16:49
@samugi samugi mentioned this pull request Nov 15, 2023
Closed
3 tasks
@StarlightIbuki StarlightIbuki added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 23, 2024
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gszr gszr gszr approved these changes

@samugi samugi samugi approved these changes

@chobits chobits Awaiting requested review from chobits

Assignees

@StarlightIbuki StarlightIbuki

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/tracing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StarlightIbuki @team-gateway-bot @gszr @samugi