Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log-serializer): do not add receive time to latencies.kong #12795

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix(log-serializer): do not add receive time to latencies.kong #12795

merged 1 commit into from
Apr 2, 2024

Conversation

flrgh
Copy link
Contributor

@flrgh flrgh commented Mar 27, 2024 •
edited
Loading

Summary

This removes receive time (latencies.receive or ctx.KONG_RECEIVE_TIME) from latencies.kong within the log serializer.

Kongers: see JIRA ticket for more context.

Checklist

Issue reference

KAG-3798

@github-actions github-actions bot added core/logs cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Mar 27, 2024
@flrgh flrgh mentioned this pull request Mar 27, 2024
Merged
2 tasks
@flrgh flrgh force-pushed the fix/log-serializer-kong-latency branch from 2413bb4 to 05ba8b0 Compare March 27, 2024 17:19
@flrgh flrgh force-pushed the fix/log-serializer-kong-latency branch from 05ba8b0 to 78f0c68 Compare March 27, 2024 17:32
nowNick
nowNick approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@nowNick nowNick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the ticket comments & the code - makes perfect sense 👍

@flrgh flrgh force-pushed the fix/log-serializer-kong-latency branch from 78f0c68 to f7dcccd Compare April 1, 2024 17:36
@flrgh flrgh merged commit d98eac9 into master Apr 2, 2024
26 checks passed
@flrgh flrgh deleted the fix/log-serializer-kong-latency branch April 2, 2024 19:35
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobSerafini RobSerafini RobSerafini approved these changes

@nowNick nowNick nowNick approved these changes

Assignees

@flrgh flrgh

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/logs size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flrgh @team-gateway-bot @nowNick @RobSerafini