Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS OPTIONS(Preflight request) request should return 204 #6051

Closed
dzmitry-lahoda opened this issue Jun 24, 2020 · 0 comments
Closed

CORS OPTIONS(Preflight request) request should return 204 #6051

dzmitry-lahoda opened this issue Jun 24, 2020 · 0 comments
Labels
good first issue Issues that beginners/volunteers can easily help with. task/feature Requests for new features in Kong

Comments

@dzmitry-lahoda
Copy link

Next line returns 200 as status

kong/kong/plugins/cors/handler.lua

Line 13 in c817fad

local HTTP_OK = 200

Internet says it should return 204:

Internet changed its mind since 2018 #4029
@gszr gszr added good first issue Issues that beginners/volunteers can easily help with. task/feature Requests for new features in Kong labels Jul 1, 2020
@thehanimo thehanimo mentioned this issue Aug 11, 2020
Closed
thehanimo added a commit to thehanimo/kong that referenced this issue Aug 11, 2020
@thehanimo
fix(cors) send HTTP 204 on Preflight request
9c175d6 
The appropriate status code for a preflight request is 204 as per the updated Mozilla guidelines (https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request). We previously used to send HTTP 200.

* return 204 for preflight response instead of 200

Fix Kong#6051
@thehanimo thehanimo mentioned this issue Aug 11, 2020
Closed
@devinivy devinivy mentioned this issue Aug 25, 2020
Closed
@devinivy devinivy mentioned this issue Sep 25, 2020
Closed
@guanlan guanlan closed this as completed May 26, 2021
@Kong Kong locked and limited conversation to collaborators May 26, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
good first issue Issues that beginners/volunteers can easily help with. task/feature Requests for new features in Kong
Projects
None yet
Milestone
No milestone
3 participants
@guanlan @dzmitry-lahoda @gszr