-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kong can't call an embedded server plugin once the plugin is killed #8293
Comments
Seems related with go plugin server configuration. |
Use below Dockerfile will fix this issue too
|
Sorry for not provided enough information, but the go-pdk version is v0.7.1. This may be the issue of go-pdk. go.mod
go.sum
|
@fr-kinoshita did you find fix ?? I have encounter same issue. |
This issue happens with go-pdk v0.7.0/v0.7.1. |
@yankun-li-kong One of plugin config contains unexported struct and in v0.6.1 it is crashing with stack overflow when run |
Fix issue where the Go plugin instance would not get updated after a plugin server restart. Fixes #8293
Hi all, We have opened #8547 with a fix for this. Please test it if you can! Thanks! |
and @fr-kinoshita, thank you for the detailed repro steps! Those were very helpful! |
@fr-kinoshita @dhrumil29699 I have the same problem, How is it solved? |
@gszr This bug when. Can be merged into the main branch? |
@yaobo-lab - I have pushed a new revision, should be good to go soon. |
Hi all, this has now been merged into Kong master, and will be included in the next release. |
Hello, any update on when this is planning to be released? |
Hello above issue was fixed in go-pdk 0.8.0 version? |
Hello, |
@Tharunvarshanth @guy-frontegg iiuc, this is not something related to kong-pdk, but with Kong instance itself, which is the responsible for handling the server lifecycle. What I've done in my case, was to switch the Kong image from 2.7.0 into a build with the commit from the MR thas patches this issue (in our usecase it was fine to use an unrelased version of Kong if that would fix our issue). You can find images for Kong commit hashes here: https://hub.docker.com/r/kong/kong |
@gszr and all, Thank you for fixing this issue and sorry for missing your comments long time.. I hope this fix will be released soon. |
I do not think it is resolved. |
Is there an existing issue for this?
Kong version (
$ kong version
)Kong 2.7.0
Current Behavior
As title, kong seems to fail to call external embedded server plugin if the plugin is killed by for example OOM. After a plugin is killed, kong outputs error logs as below, but the request succeeds.
Expected Behavior
Best is Kong can call external embedded server plugin even after the plugin is killed.
Steps To Reproduce
I have tested in docker environment of my local laptop.
Example go plugin (from https://github.com/Kong/go-plugins/blob/master/go-hello.go)
Dockerfile of kong
docker-compose.yml
kong.yml
Steps to reproduce
In this time, x-hello-from-go exists in response header
After login to kong and kill plugin process, request succeeds but x-hello-from-go does not exist in response header.
Kong outputs error log as below.
However, hello plugin is running with different process id.
Anything else?
No response
The text was updated successfully, but these errors were encountered: