fix(*): prevent queues from growing without bounds #10046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanshuebner
changed the title
flrgh
reviewed
Jan 3, 2023
kikito
requested changes
Jan 3, 2023
hanshuebner
force-pushed
the
kag-303-batch-queue-limit
branch
from
411d661
to
54d05ca
Compare
github-actions
bot
added
core/configuration
plugins/datadog
plugins/http-log
plugins/opentelemetry
plugins/statsd
and removed
core/templates
core/pdk
labels
hanshuebner
force-pushed
the
kag-303-batch-queue-limit
branch
from
54d05ca
to
7d1da05
Compare
added 4 commits
January 4, 2023 15:41
This commit implements an upper limit on the number of batches that may be waiting on a queue for processing. Once the limit has been reached, the oldest batch is dropped from the queue and an error message is logged. The maximum number of batches that can be waiting on a queue is configured through the max_queued_batches parameter of the queue, which defaults to 100. KAG-303
hanshuebner
force-pushed
the
kag-303-batch-queue-limit
branch
from
f8846d6
to
7f7a701
Compare
kikito
approved these changes
Jan 4, 2023
kikito
pushed a commit
that referenced
this pull request
Feb 8, 2023
* fix(*): prevent queues from growing without bounds (#10046) This commit implements an upper limit on the number of batches that may be waiting on a queue for processing. Once the limit has been reached, the oldest batch is dropped from the queue and an error message is logged. The maximum number of batches that can be waiting on a queue is configured through the max_queued_batches parameter of the queue, which defaults to 100 and can be globally overriden with the max_queued_batches parameter in kong.conf KAG-303 This reverts commit 218cc0a. * fix(*): need to actually wait for queue to be processed 2.8 uses the ngx native timers that behave slightly differently when sleep(0) is invoked
kikito
pushed a commit
that referenced
this pull request
Feb 8, 2023
This commit implements an upper limit on the number of batches that may be waiting on a queue for processing. Once the limit has been reached, the oldest batch is dropped from the queue and an error message is logged. The maximum number of batches that can be waiting on a queue is configured through the max_queued_batches parameter of the queue, which defaults to 100 and can be globally overriden with the max_queued_batches parameter in kong.conf A more complete rewrite of the queuing system is in the works but will not make it into 3.2. KAG-303 This reverts commit 218cc0a.
kikito
pushed a commit
that referenced
this pull request
Feb 8, 2023
This commit implements an upper limit on the number of batches that may be waiting on a queue for processing. Once the limit has been reached, the oldest batch is dropped from the queue and an error message is logged. The maximum number of batches that can be waiting on a queue is configured through the max_queued_batches parameter of the queue, which defaults to 100 and can be globally overriden with the max_queued_batches parameter in kong.conf KAG-303 This reverts commit 218cc0a.
kikito
pushed a commit
that referenced
this pull request
Feb 8, 2023
This commit implements an upper limit on the number of batches that may be waiting on a queue for processing. Once the limit has been reached, the oldest batch is dropped from the queue and an error message is logged. The maximum number of batches that can be waiting on a queue is configured through the max_queued_batches parameter of the queue, which defaults to 100 and can be globally overriden with the max_queued_batches parameter in kong.conf KAG-303 This reverts commit 218cc0a.
AndyZhang0707
added a commit
that referenced
this pull request
Aug 24, 2023
AndyZhang0707
added a commit
that referenced
this pull request
Aug 24, 2023
AndyZhang0707
added a commit
that referenced
this pull request
Aug 24, 2023
AndyZhang0707
added a commit
that referenced
this pull request
Sep 18, 2023
AndyZhang0707
added a commit
that referenced
this pull request
Sep 18, 2023
AndyZhang0707
added a commit
that referenced
this pull request
Sep 18, 2023
dndx
pushed a commit
that referenced
this pull request
Sep 19, 2023
dndx
pushed a commit
that referenced
this pull request
Sep 19, 2023
dndx
pushed a commit
that referenced
this pull request
Sep 19, 2023
AndyZhang0707
added a commit
that referenced
this pull request
Dec 4, 2023
AndyZhang0707
added a commit
that referenced
this pull request
Dec 4, 2023
windmgc
pushed a commit
that referenced
this pull request
Dec 11, 2023
windmgc
pushed a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit implements an upper limit on the number of batches that may be waiting on a queue for processing. Once the limit has been reached, the oldest batch is dropped from the queue and an error message is logged. The maximum number of batches that can be waiting on a queue is configured through the max_queued_batches parameter of the queue, which defaults to 100.
KAG-303
Checklist