-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): route/service scoping #10096
Conversation
e986bdb
to
cadb824
Compare
cadb824
to
7c0d97b
Compare
c0f5ec9
to
7e9a67d
Compare
8ad190e
to
91f4f19
Compare
ebb74d2
to
434d077
Compare
434d077
to
5e73cab
Compare
I feel like we are mixing the source of truth of "whether to trace or not" in different places. Previously when
In this PR we have an additional source of truth on "whether to trace or not" depending on if any of a tracing
so that we don't need complex logic over iterration over plugins and cache invalidations. |
f1c72e4
to
8a408d6
Compare
🤦You are right. The code could be much more straightforward. I am rewriting the code. |
implement KAG-244