fix(template) keep UTF-8 as default for charset directive but make it configurable #10111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
fix/charset-default
branch
from
6d9ede3 to
1dc20d7
Compare
dndx
added
the
pr/discussion
bungle
force-pushed
the
fix/charset-default
branch
2 times, most recently
from
36d7194 to
003eac4
Compare
bungle
force-pushed
the
fix/charset-default
branch
2 times, most recently
from
7a31829 to
0f045c2
Compare
colinh-kong
approved these changes
Jan 13, 2023
bungle
force-pushed
the
fix/charset-default
branch
from
0f045c2 to
8efa2d6
Compare
… configurable ### Summary `charset` directive that was previously hard coded in template with a value of `UTF-8` was removed completely with this PR: #9905 Previous discussion from 3 years ago pointed that this is breaking change (not a fix): #5045 So here is another fix to make the directive still default to `UTF-8`. which is a quite fine default, but allow users to configure it. E.g.: ``` KONG_NGINX_HTTP_CHARSET=off kong start ```
bungle
force-pushed
the
fix/charset-default
branch
from
8efa2d6 to
f8fe021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
charsetdirective that was previously hard coded in template with a value ofUTF-8was removed completely with this PR:#9905
Previous discussion from 3 years ago pointed that this is breaking change (not a fix): #5045
So here is another fix to make the directive still default to
UTF-8. which is a quite fine default, but allow users to configure it. E.g.:FTI-4551