-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): dynamically sets log level for timers pre-created by timer-ng #10133
Conversation
Just a note, we made a workaround within timer-ng, and while it still has some limitations, we're at least going to make this feature (dynamic log_level) work. In the future, we should rewrite the C code to implement this feature elegantly, and @gruceo will create internal tickets to track this thiing. |
@gruceo can you check the failed tests, please? |
I suggest we take this PR out of 3.2.0 as the hack is too specific to the timer library we use and I have a feeling that there is a better and more systematic way to fix these and similar issues. @ADD-SP can help get this moving towards that direction. @kikito @guanlan any objections? This does not looks too urgent to me. |
c44c1d8
to
a6a3c9f
Compare
If the log level was dynamically set, we must also change the log level for all timers pre-created by the timer-ng library. We're going to use the global _G table and not a shared dictionary due to performance reasons.
a6a3c9f
to
3fa52e9
Compare
@dndx thank you for your suggestion, I dropped a comment to KAG-457. Tests are passing now. Note this bug does not happen with native |
If the log level was dynamically set, we must also change the log level for all timers pre-created by the timer-ng library.
We're going to use the global _G table and not a shared dictionary due to performance reasons.