-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat/container-scanning): Integrate container and cve scanning post … #10272
Conversation
3cd264d
to
1d458fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. I've penned up some minor improvements in #10273
* chore(gha): cleanup trailing whitespace * chore(gha): simplify release scan image as ENV * chore(gha): simplify release scan logic * fix(gha): release scan IMAGE context
2bd640d
to
17b2fee
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.8.x release/2.8.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.8.x
# Create a new branch
git switch --create backport-10272-to-release/2.8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d9bdd828f92c25c50e5d39d6d53a2fbac443771c
# Push it to GitHub
git push --set-upstream origin backport-10272-to-release/2.8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.8.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.1.x release/3.1.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.1.x
# Create a new branch
git switch --create backport-10272-to-release/3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d9bdd828f92c25c50e5d39d6d53a2fbac443771c
# Push it to GitHub
git push --set-upstream origin backport-10272-to-release/3.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.2.x release/3.2.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.2.x
# Create a new branch
git switch --create backport-10272-to-release/3.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d9bdd828f92c25c50e5d39d6d53a2fbac443771c
# Push it to GitHub
git push --set-upstream origin backport-10272-to-release/3.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.2.x Then, create a pull request where the |
#10272) * (feat/container-scanning): Integrate container and cve scanning post publishing * build/ENGEN-844 review (#10273) * chore(gha): cleanup trailing whitespace * chore(gha): simplify release scan image as ENV * chore(gha): simplify release scan logic * fix(gha): release scan IMAGE context * chore(gha): fix scan manifest output redirection --------- Co-authored-by: Isa Farnik <isa@konghq.com>
@saisatishkarra I just realized I left comment only on the backport PR on release/3.2.x branch and didn't |
Backported from #10272 * (feat/container-scanning): Integrate container and cve scanning post … (#10272) * (feat/container-scanning): Integrate container and cve scanning post publishing * build/ENGEN-844 review (#10273) * chore(gha): cleanup trailing whitespace * chore(gha): simplify release scan image as ENV * chore(gha): simplify release scan logic * fix(gha): release scan IMAGE context * chore(gha): fix scan manifest output redirection --------- Co-authored-by: Isa Farnik <isa@konghq.com> * fix(cd): remove container scan dependency --------- Co-authored-by: Isa Farnik <isa@konghq.com>
…publishing
Summary
Expected outcome
Checklist
Full changelog
Issue reference
Fix #[issue number]