Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dynamic_log_level): support timeout for dynamic log level #10288

Merged
merged 1 commit into from
Apr 27, 2023
Merged

feat(dynamic_log_level): support timeout for dynamic log level #10288

merged 1 commit into from
Apr 27, 2023

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Feb 13, 2023 •
edited by jira bot
Loading

@ADD-SP ADD-SP changed the title refactor(dynamic_log_level): add API to dynamically set Nginx log lev… refactor(dynamic_log_level): add API to dynamically set Nginx log levels from Lua land Feb 13, 2023
@ADD-SP ADD-SP mentioned this pull request Feb 13, 2023
Merged
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch 4 times, most recently from 0bdb6f3 to 1e155c4 Compare February 13, 2023 12:50
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch from c1710e8 to 09fd443 Compare March 29, 2023 02:01
@ADD-SP ADD-SP marked this pull request as ready for review March 29, 2023 02:47
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch 4 times, most recently from 5daef0a to b2e4fdc Compare March 30, 2023 09:15
@ADD-SP ADD-SP changed the title refactor(dynamic_log_level): add API to dynamically set Nginx log levels from Lua land feat(dynamic_log_level): support timeout for dynamic log level Mar 30, 2023
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch 3 times, most recently from eded161 to 8a9f16d Compare April 6, 2023 09:03
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch 2 times, most recently from 3dc6952 to 5d76710 Compare April 7, 2023 06:47
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch 2 times, most recently from 206485c to 43f328c Compare April 9, 2023 10:39
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch from 9060c35 to 5366ba2 Compare April 10, 2023 03:12
@ADD-SP ADD-SP added this to the 3.3 milestone Apr 10, 2023
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch from 5366ba2 to d4e2610 Compare April 13, 2023 06:08
chronolaw
chronolaw approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@chronolaw chronolaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When lua-kong-module releases the new version, this PR is ready to merge.

@chronolaw
Copy link
Contributor

Should we add a change log entry to describe this new feature?

@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch from b393a29 to f111fd5 Compare April 17, 2023 02:58
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch from f111fd5 to 4f94208 Compare April 17, 2023 03:10
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch 2 times, most recently from 680137e to 51d5fb1 Compare April 17, 2023 04:50
fffonion
fffonion reviewed Apr 24, 2023
View reviewed changes
kong/api/routes/debug.lua Outdated Show resolved Hide resolved
gruceo
gruceo reviewed Apr 26, 2023
View reviewed changes
kong/api/routes/debug.lua Outdated Show resolved Hide resolved
spec/02-integration/04-admin_api/22-debug_spec.lua Show resolved Hide resolved
autodoc/admin-api/data/admin-api.lua Outdated Show resolved Hide resolved
kong/runloop/handler.lua Outdated Show resolved Hide resolved
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch from 9a49fe2 to beff730 Compare April 27, 2023 03:18
@outsinre
Copy link
Contributor

Will cherry-pick by @ADD-SP .

@ADD-SP ADD-SP closed this Apr 27, 2023
@ADD-SP ADD-SP reopened this Apr 27, 2023
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch from 0a7ea61 to 181348d Compare April 27, 2023 06:59
chronolaw
chronolaw reviewed Apr 27, 2023
View reviewed changes
autodoc/admin-api/data/admin-api.lua Outdated Show resolved Hide resolved
autodoc/admin-api/data/admin-api.lua Outdated Show resolved Hide resolved
autodoc/admin-api/data/admin-api.lua Outdated Show resolved Hide resolved
@ADD-SP @gruceo @chronolaw
feat(dynamic_log_level): support timeout for dynamic log level
d52bddc 
Co-authored-by: Murillo <103451714+gruceo@users.noreply.github.com>
Co-authored-by: Chrono <chrono_cpp@me.com>
@ADD-SP ADD-SP force-pushed the add_sp/refactor-dynamic-log-level branch from 181348d to d52bddc Compare April 27, 2023 07:17
@fffonion fffonion merged commit 13691a0 into master Apr 27, 2023
@fffonion fffonion deleted the add_sp/refactor-dynamic-log-level branch April 27, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

@gruceo gruceo gruceo left review comments

@hanshuebner hanshuebner hanshuebner approved these changes

@fffonion fffonion fffonion approved these changes

@oowl oowl oowl approved these changes

Assignees

@ADD-SP ADD-SP

Labels
autodoc build/bazel changelog core/admin-api core/proxy size/L
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ADD-SP @chronolaw @outsinre @hanshuebner @fffonion @oowl @gruceo