fix(plugin): compat issue for config sync #10346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 3.2, we added `aws_imds_protocol_version` for `aws_lambda` plugin, and `aws_imds_protocol_version` for `zipkin` plugin, but we did not add corresponding `removed_fields` entries. Fix KAG-725
StarlightIbuki
force-pushed
the
fix/aws_lambda_compat
branch
from
669d94e
to
2672d24
Compare
StarlightIbuki
changed the title
chronolaw
reviewed
Feb 22, 2023
Co-authored-by: Chrono <chronolaw@gmail.com>
dndx
approved these changes
Feb 22, 2023
|
I've manually tested the change and it works with 3.1.1.2. https://gist.github.com/StarlightIbuki/ee9f47617c165961e5aca2e60a23bf39 Using the compose and config it with new fields, we see the config is synced. |
mashapedeployment
pushed a commit
that referenced
this pull request
Feb 22, 2023
For 3.2, we added `aws_imds_protocol_version` config for `aws_lambda` plugin, and `aws_imds_protocol_version` config for `zipkin` plugin, but we did not add corresponding `removed_fields` entries. Which causes Hybrid mode sync to older versions of Kong to fail. Fix KAG-725 Co-authored-by: Chrono <chronolaw@gmail.com> (cherry picked from commit 2a23672)
|
Adding a comment just to confirm that the fix worked fine in my manual tests too. |
dndx
pushed a commit
that referenced
this pull request
Feb 23, 2023
For 3.2, we added `aws_imds_protocol_version` config for `aws_lambda` plugin, and `aws_imds_protocol_version` config for `zipkin` plugin, but we did not add corresponding `removed_fields` entries. Which causes Hybrid mode sync to older versions of Kong to fail. Fix KAG-725 Co-authored-by: Chrono <chronolaw@gmail.com> (cherry picked from commit 2a23672)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For 3.2, we added
aws_imds_protocol_versionforaws_lambdaplugin, andaws_imds_protocol_versionforzipkinplugin, but we did not add correspondingremoved_fieldsentries.Checklist
The Pull Request has tests -- N/A, we removed tests to
removed_filedsas it does not mean much but causes flakiness.There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com -- N/A, it's a bug fix
Issue reference
Fix KAG-725