Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(otel): add http_response_header_for_traceid config to add trace_id for downstream header #10379

Merged
merged 6 commits into from
Mar 17, 2023
Merged

feat(otel): add http_response_header_for_traceid config to add trace_id for downstream header #10379

merged 6 commits into from
Mar 17, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Feb 27, 2023 •
edited
Loading

Summary

add http_response_header_for_traceid config to add trace_id to the downstream header.

Checklist

Full changelog

  • [Implement ...]

Issue reference

FTI-4655

@oowl oowl changed the title feat(otel): add http_response_header_for_traceid config to add trace_id to downstream header feat(otel): add http_response_header_for_traceid config to add trace_id for downstream header Feb 27, 2023
@oowl oowl force-pushed the otel/downstream-traceid branch from 7e3e794 to 6bc2343 Compare February 27, 2023 09:53
@hbagdi hbagdi added the version-compatibility Incompatibility with older data plane versions label Mar 1, 2023
@oowl oowl force-pushed the otel/downstream-traceid branch from 6bc2343 to 94b1af9 Compare March 14, 2023 07:12
@oowl oowl force-pushed the otel/downstream-traceid branch 3 times, most recently from 159b556 to 4a5584c Compare March 15, 2023 07:27
@ms2008 ms2008 self-requested a review March 16, 2023 01:48
ms2008
ms2008 reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@ms2008 ms2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase from the master, and resolve the new conflicts.

@oowl oowl force-pushed the otel/downstream-traceid branch 3 times, most recently from 37bd641 to 679eea6 Compare March 16, 2023 07:14
@oowl oowl force-pushed the otel/downstream-traceid branch from 679eea6 to df2bdbd Compare March 16, 2023 09:12
@fffonion fffonion merged commit b045c1e into master Mar 17, 2023
@fffonion fffonion deleted the otel/downstream-traceid branch March 17, 2023 06:01
@lena-larionova lena-larionova mentioned this pull request Nov 3, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion left review comments

@ms2008 ms2008 ms2008 approved these changes

@GGabriele GGabriele GGabriele left review comments

Assignees
No one assigned
Labels
changelog core/clustering plugins/opentelemetry schema-change-noteworthy size/M version-compatibility Incompatibility with older data plane versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oowl @fffonion @ms2008 @GGabriele @hbagdi