Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): add http2 smoke test #10454

Merged
merged 9 commits into from
Mar 9, 2023
Merged

chore(tests): add http2 smoke test #10454

merged 9 commits into from
Mar 9, 2023

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Mar 8, 2023

Summary

This PR adds a simple smoke test to check if the HTTP/2 listening port can respond with valid response data.

Checklist

Full changelog

  • [Implement ...]

Issue reference

KAG-854

@github-actions github-actions bot added build/bazel chore Not part of the core functionality of kong, but still needed labels Mar 8, 2023
@windmgc windmgc mentioned this pull request Mar 8, 2023
Closed
3 tasks
@windmgc windmgc force-pushed the chore-add-http2-smoke-test branch from f921d21 to 0fda30a Compare March 8, 2023 12:41
@windmgc windmgc force-pushed the chore-add-http2-smoke-test branch from 0fda30a to 44c336d Compare March 8, 2023 13:47
@windmgc
Copy link
Member Author

windmgc commented Mar 8, 2023

@fffonion Please take a look at the smoke test result and after that I can revert the temp commit

fffonion
fffonion approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@fffonion fffonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge after change in matrix-commitly.yml is reverted

@windmgc
Copy link
Member Author

windmgc commented Mar 8, 2023

@fffonion change reverted.

gszr
gszr previously requested changes Mar 8, 2023
View reviewed changes
build/tests/03-http2-admin-api.sh Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 9, 2023
@windmgc
Copy link
Member Author

windmgc commented Mar 9, 2023

I added back both ubuntu/debian/alpine/rhel build image for the smoke test.

@fffonion Please check here https://github.com/Kong/kong/actions/runs/4371032112/jobs/7646663545 again for the result.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Mar 9, 2023
@fffonion fffonion dismissed gszr’s stale review March 9, 2023 04:40

dismiss as resovled

@fffonion fffonion merged commit 40c572d into master Mar 9, 2023
@fffonion fffonion deleted the chore-add-http2-smoke-test branch March 9, 2023 04:42
@team-gateway-bot team-gateway-bot mentioned this pull request Mar 9, 2023
Merged
team-gateway-bot pushed a commit that referenced this pull request Mar 9, 2023
@windmgc @github-actions
chore(cd): add http2 smoke test (#10454)
78c25a0 
This PR adds a simple smoke test to check if the HTTP/2 listening port can respond with valid response data.

KAG-854

(cherry picked from commit 40c572d)
fffonion pushed a commit that referenced this pull request Mar 9, 2023
@team-gateway-bot @windmgc
chore(cd): add http2 smoke test (#10454) (#10459)
e67b8c4 
This PR adds a simple smoke test to check if the HTTP/2 listening port can respond with valid response data.

KAG-854

(cherry picked from commit 40c572d)

Co-authored-by: Qirui(Keery) Nie <windmgc@gmail.com>
This was referenced Mar 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

@gszr gszr gszr left review comments

Assignees
No one assigned
Labels
build/bazel chore Not part of the core functionality of kong, but still needed size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@windmgc @fffonion @gszr