Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin): custom id empty value cause crash #10475

Merged
merged 4 commits into from
Mar 17, 2023
Merged

fix(admin): custom id empty value cause crash #10475

merged 4 commits into from
Mar 17, 2023

Conversation

StarlightIbuki
Copy link
Contributor

Checklist

  • The Pull Request has tests
  • There's an entry in the CHANGELOG

N/A There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-867

@StarlightIbuki StarlightIbuki force-pushed the fix/admin-500-emtpy-arg branch 2 times, most recently from 761d384 to 5fbf7a2 Compare March 15, 2023 08:21
@StarlightIbuki @chronolaw
fix(admin): custom id empty value cause crash
7bac022 
Fix KAG-867

Co-authored-by: Chrono <chrono_cpp@me.com>
@bungle bungle merged commit 39e5f34 into master Mar 17, 2023
@bungle bungle deleted the fix/admin-500-emtpy-arg branch March 17, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbagdi hbagdi hbagdi left review comments

@chronolaw chronolaw chronolaw approved these changes

@bungle bungle bungle approved these changes

Assignees
No one assigned
Labels
changelog core/admin-api size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StarlightIbuki @bungle @chronolaw @hbagdi