fix(runloop): use upstream status code in passive health check (#10325) #10518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We expect the upstream passive unhealthy healthcheck on HTTP status code should only mark the targets as "down" (not reachable or proxiable) using the returned HTTP status code from the target, and it should not be affected by the final HTTP status code set by Kong plugin, which is returned to the client. So we change the passive health check implementation to use nginx var `upstream_code`, this will not be changed by any plugin. FTI-4841 Fix #10281 (cherry picked from commit dbe8d94)
|
@attenuation please review and approve if this PR matches your fix in #10325. |
oowl
approved these changes
Mar 21, 2023
lhanjian
pushed a commit
that referenced
this pull request
Dec 23, 2024
…g will block migration upgrade to 3.8 (#10518) * fix(migration): the SQL of deprecated redis timeout does not consider the situation where existing plugins's configurations do not have redis config The original SQL of deprecated timeout config field in redis config did not consider the situation where the existing plugins's configuration did not have the redis config. This fix updates the SQL to only process plugins's configurations that have the redis config. Fix: [FTI-6287](https://konghq.atlassian.net/browse/FTI-6287) --------- Signed-off-by: tzssangglass <tzssangglass@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect the upstream passive unhealthy healthcheck on HTTP status code should only mark the targets as "down" (not reachable or proxiable) using the returned HTTP status code from the target, and it should not be affected by the final HTTP status code set by Kong plugin, which is returned to the client.
So we change the passive health check implementation to use nginx var
upstream_code, this will not be changed by any plugin.FTI-4841
Fix #10281
(cherry picked from commit dbe8d94)
Summary
Checklist
Full changelog
Issue reference
FTI-4802