-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin): do not shorten id when not w3c #10531
Conversation
9b4cc86
to
4d92ef2
Compare
e91bc9b
to
3da00da
Compare
f183489
to
3eb782f
Compare
96a8ae0
to
a4e10e6
Compare
22b1847
to
a450983
Compare
end | ||
|
||
return trace_id | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would better if we have a single "to_provider_trace_id(trace_id,provider_type)" and unit test the heck out of it instead of ensuring that we call the right function in the right if branch below.
Not a blocker for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. But let's wait until another larger round of refactoring to fix long-term issues.
Co-authored-by: Harry <harrybagdi@gmail.com> Co-authored-by: Samuele Illuminati <samuele@konghq.com>
af77d59
to
4991dca
Compare
ready to cherry-pick on EE @StarlightIbuki |
Summary
A bug was introduced when trying to fix the tracing ID length issue.
We should only adjust the ID for specific headers instead of before calling
propagate
.Checklist
Issue reference
Fix KAG-652