Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tracing): add net.peer.name attribute if balancer_data.hostname is available #10729

Merged
merged 7 commits into from
Jul 18, 2023
Merged

feat(tracing): add net.peer.name attribute if balancer_data.hostname is available #10729

merged 7 commits into from
Jul 18, 2023

Conversation

backjo
Copy link
Contributor

@backjo backjo commented Apr 24, 2023 •
edited
Loading

This records the upstream hostname if available on the balancer spans.

Summary

Checklist

Full changelog

Added new span attribute net.peer.name if balancer_data.hostname is available.

Issue reference

Fix #[issue number]

feat(tracing): add net.peer.name attribute if balancer_data.hostname …
6bae266 
…is available

This records the upstream hostname if available on the balancer spans.
oowl
oowl reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as #10723 (comment), Please try to add some tests to this.

@StarlightIbuki
Copy link
Contributor

StarlightIbuki commented Apr 26, 2023 •
edited
Loading

same as #10723 (comment), Please try to add some tests to this.

And also the changelog.

@hbagdi hbagdi requested a review from samugi May 8, 2023 21:27
@oowl
Copy link
Member

oowl commented May 15, 2023

@backjo Any update here?

@CLAassistant
Copy link

CLAassistant commented Jun 5, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@samugi samugi added the pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc... label Jun 5, 2023
@StarlightIbuki
Copy link
Contributor

StarlightIbuki commented Jun 6, 2023 •
edited
Loading

We force-pushed to the master recently so the history is messed up. Could you rebase the PR towards the master so it can be reviewable?

@stale
Copy link

stale bot commented Jun 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 22, 2023
@hbagdi hbagdi added the author/community PRs from the open-source community (not Kong Inc) label Jun 26, 2023
@stale stale bot removed the stale label Jun 26, 2023
@hbagdi
Copy link
Member

hbagdi commented Jun 27, 2023

@backjo Are you still interested in getting this PR to completion?

@backjo
Copy link
Contributor Author

backjo commented Jul 12, 2023

@hbagdi yep, cleaning it up rn

@backjo
Copy link
Contributor Author

backjo commented Jul 12, 2023

@hbagdi this is good to go I think

@backjo backjo requested a review from oowl July 13, 2023 02:09
@oowl
Copy link
Member

oowl commented Jul 13, 2023

waiting for merged, And then I will do another cherry-pick-related job.

@StarlightIbuki @chronolaw
Update CHANGELOG.md
91f7c49 
Co-authored-by: Chrono <chronolaw@gmail.com>
@StarlightIbuki StarlightIbuki removed the pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc... label Jul 14, 2023
StarlightIbuki
StarlightIbuki approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@guanlan guanlan merged commit c657a2c into Kong:master Jul 18, 2023
lhanjian pushed a commit that referenced this pull request Dec 23, 2024
@liverpool8056
fix(plugin/exit-transformer): should take effect on invalid non-admin…
e0ecbde 
… requests (#10729)

* fix(plugin/exit-transformer): fix a bug where the exit-transformer could
not take effect on invalid non-admin requests

FTI-6344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw left review comments

@oowl oowl oowl approved these changes

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@samugi samugi Awaiting requested review from samugi

Assignees
No one assigned
Labels
author/community PRs from the open-source community (not Kong Inc) changelog core/tracing size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@backjo @StarlightIbuki @oowl @CLAassistant @hbagdi @chronolaw @guanlan @samugi