fix(status): CP /status/ready return 503 when DB is off #10787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locao
force-pushed
the
fix/cp-readiness-status
branch
2 times, most recently
from
147fb7e to
5bf391a
Compare
Co-authored-by: Guilherme Salazar <gsz@acm.org>
locao
force-pushed
the
fix/cp-readiness-status
branch
from
8920f91 to
37640a7
Compare
team-gateway-bot
pushed a commit
that referenced
this pull request
May 5, 2023
* fix(status): CP /status/ready return 503 when DB is off Co-authored-by: Guilherme Salazar <gsz@acm.org> * docs(CHANGELOG.md) update feature entry --------- Co-authored-by: Guilherme Salazar <gsz@acm.org> (cherry picked from commit c7de58c)
locao
added a commit
that referenced
this pull request
May 5, 2023
) * fix(status): CP /status/ready return 503 when DB is off Co-authored-by: Guilherme Salazar <gsz@acm.org> * docs(CHANGELOG.md) update feature entry --------- Co-authored-by: Guilherme Salazar <gsz@acm.org> (cherry picked from commit c7de58c) Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the behavior of the new readiness endpoint for control plane nodes.
The new endpoint
/status/readyadded in #10610 checks if Kong Gateway is ready for proxying. This check only makes sense in data plane nodes, as control plane nodes don't proxy traffic. But the response could be misleading, control plane nodes failing to connect to the database would return200 OK, even if they are not functional.Note: this PR has no automated tests, our test suite does not support stopping the database while the tests are running.
Checklist
Full changelog
Issue reference
KAG-1437