Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): patch ngx_lua-1.21.4_07-print-body-double-free bug fix #10816

Merged
merged 4 commits into from
May 9, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented May 9, 2023

Summary

Backported the openresty ngx.print chunk encoding buffer double free bug fix that leads to the corruption of chunk-encoded response data.
openresty/lua-nginx-module#2115

Issues context:
openresty/lua-nginx-module#2184

Related: openresty/lua-nginx-module#2184

Checklist

Issue reference

FTI-5051

@oowl oowl marked this pull request as draft May 9, 2023 02:56
@chronolaw chronolaw added this to the 3.3.0 milestone May 9, 2023
@oowl oowl marked this pull request as ready for review May 9, 2023 03:13
Copy link
Contributor

@ms2008 ms2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be more appropriate to name the patch file starting with ngx_lua-0.10.21?

@chronolaw
Copy link
Contributor

The patch file should start with ngx_lua-0.10.21?

Yes, in OpenResty 1.21.41 ngx_lua is 0.10.21

@oowl oowl force-pushed the fix/ngx-print-double-free branch from a304fe8 to ad4f8cd Compare May 9, 2023 03:21
@bungle
Copy link
Member

bungle commented May 9, 2023

I tested it locally on mac and it works.

@bungle bungle merged commit 4dd3a34 into master May 9, 2023
@bungle bungle deleted the fix/ngx-print-double-free branch May 9, 2023 08:15
team-gateway-bot pushed a commit that referenced this pull request May 9, 2023
team-gateway-bot pushed a commit that referenced this pull request May 9, 2023
team-gateway-bot pushed a commit that referenced this pull request May 9, 2023
bungle pushed a commit that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants