Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(changelog): update changelog for 3.3.0 with the released one #10909

Merged
merged 1 commit into from
May 19, 2023

Conversation

kikito
Copy link
Member

@kikito kikito commented May 19, 2023

I revised the changes one by one. Besides trivial changes in punctuation/order:

#10783 (Reports: fix a potential issue that could cause socket leaks. and loggly & tcp-log & udp-log: fix a potential issue that could cause socket leaks.) was resolved after code freeze and was not backported to 3.3 - its changelog entry was put in the wrong place

Summary

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

I revised the changes one by one. Besides trivial changes in punctuation/order:

#10783 (Reports: fix a potential issue that could cause socket leaks. and **loggly & tcp-log & udp-log**: fix a potential issue that could cause socket leaks.) was resolved after code freeze and was not backported to 3.3 - its changelog entry was put in the wrong place

#
@@ -149,6 +149,7 @@
[#10288](https://github.com/Kong/kong/pull/10288)
- Added new span attribute `http.client_ip` to capture the client IP when behind a proxy.
[#10723](https://github.com/Kong/kong/pull/10723)
[#10204](https://github.com/Kong/kong/pull/10204)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? I didn't follow the PR, but it does not seem related. If it is, we may want to add a shout-out to the author here as well.

Copy link
Contributor

@locao locao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this PR with my previous comment. We are merging 3.3.0 to master, so even if it is a mistake, it has to be there and then fixed.

@locao locao merged commit fa8ee36 into master May 19, 2023
@locao locao deleted the docs-3.3-changelog branch May 19, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants