fix(zipkin): do not reuse propagated_span by default
#10983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zipkin manages its spans and calls `finish` on them, and the result is that `finish` is called twice if instrumentations are enabled. Then an assertion error is generated, resulting in the span not being sent correctly. This was an issue introduced with #10663 So my approach is not to store the propagation span if the reuse parameter is not specified, in order to avoid the traces not being generated correctly under that.
ms2008
force-pushed
the
fix/zipkin-proxy_span-reuse
branch
from
4a7da84 to
ee4feb5
Compare
samugi
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Zipkin manages its spans and calls
finishon them, and the result is thatfinishis called twice if instrumentations are enabled. Then an assertion error is generated, resulting in the span not being sent correctly. This was an issue introduced with #10663So my approach is not to store the propagation span if the reuse parameter is not specified, in order to avoid the traces not being generated correctly under that.
Checklist
Full changelog
propagated_spanby defaultIssue reference
Fix FTI-5094