-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api/status): remove the database status in dbless mode and data-plane #10995
Conversation
How about setting |
The database is irrelevant in the dbless mode and data-plane. Leaving the information there may lead to some confusions and the customer may need to think/investigate why it's not reachable. So I'd prefer removing the irrelevant information from the status api completely to eliminate the confusion, but I'm open for suggestions. |
It looks reasonable. |
9afaf89
to
721207d
Compare
2721020
to
bfc0eef
Compare
Remove the meaningless database status information from the status API when operating in dbless mode or data plane.
Remove the meaningless database status information from the status API when operating in dbless mode or data plane.
Add PR to the changelog and also format the code a little bit.
bfc0eef
to
7e53e37
Compare
Summary
Remove the meaningless database status information from the status API when operating in dbless mode or data plane.
Checklist
Full changelog
Issue reference
Fix FTI-5034