-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracing): ensure sampling rate applies to whole trace #11135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
fix/sampling-rate-individual-spans
branch
from
June 27, 2023 22:12
b55ce08
to
f8f1246
Compare
samugi
commented
Jun 27, 2023
samugi
force-pushed
the
fix/sampling-rate-individual-spans
branch
from
June 28, 2023 07:43
f8f1246
to
125eb3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically OK.
samugi
commented
Jun 28, 2023
StarlightIbuki
approved these changes
Jun 29, 2023
This commit fixes a bug where the sampling rate was applied to individual spans, so configuring values of sampling_rate < 1 would sometimes result in split traces being reported. The fix ensures that the sampled flag that is calculated by the sampler for the root span is propagated to all children within the same trace.
samugi
force-pushed
the
fix/sampling-rate-individual-spans
branch
from
June 29, 2023 09:45
49040b7
to
9d45e72
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.3.x release/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.3.x
# Create a new branch
git switch --create backport-11135-to-release/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cee8965e3e270e481d390f64a4960dcb5824ff63
# Push it to GitHub
git push --set-upstream origin backport-11135-to-release/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.3.x Then, create a pull request where the |
3 tasks
kikito
pushed a commit
that referenced
this pull request
Sep 26, 2023
* fix(tracing): ensure sampling rate applies to whole trace This commit fixes a bug where the sampling rate was applied to individual spans, so configuring values of sampling_rate < 1 would sometimes result in split traces being reported. The fix ensures that the sampled flag that is calculated by the sampler for the root span is propagated to all children within the same trace. * fix(tracing): suggestions + propagation test
samugi
added a commit
that referenced
this pull request
Sep 27, 2023
* fix(tracing): ensure sampling rate applies to whole trace This commit fixes a bug where the sampling rate was applied to individual spans, so configuring values of sampling_rate < 1 would sometimes result in split traces being reported. The fix ensures that the sampled flag that is calculated by the sampler for the root span is propagated to all children within the same trace. * fix(tracing): suggestions + propagation test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes a bug where the sampling rate was applied to individual spans.
Problem: when sampling_rate is < 1 and the root span is not sampled, children (that are sampled) are reported without a parent so traces are split (producing multiple traces with different trace IDs for a single request).
The fix ensures that the sampled flag that is calculated by the sampler for the root span is propagated to all children in the same trace.
Checklist
There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREFull changelog
Issue reference
KAG-1926