fix(*): drop luasocket in cli #11177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catbro666
force-pushed
the
bin-kong-to-lua-script
branch
from
533c329
to
5effcad
Compare
2 tasks
ms2008
reviewed
Jul 11, 2023
Tieske
reviewed
Jul 11, 2023
catbro666
force-pushed
the
bin-kong-to-lua-script
branch
from
5effcad
to
5ed1a50
Compare
catbro666
force-pushed
the
drop-luasocket-in-cli
branch
from
3dde2a4
to
e91848a
Compare
catbro666
force-pushed
the
drop-luasocket-in-cli
branch
from
e91848a
to
e12c616
Compare
catbro666
force-pushed
the
bin-kong-to-lua-script
branch
from
a54bd05
to
716612b
Compare
catbro666
force-pushed
the
drop-luasocket-in-cli
branch
from
e12c616
to
8a47bd2
Compare
catbro666
force-pushed
the
bin-kong-to-lua-script
branch
from
f0e3a81
to
69079ad
Compare
catbro666
force-pushed
the
drop-luasocket-in-cli
branch
from
1ea32d1
to
16d4603
Compare
catbro666
force-pushed
the
drop-luasocket-in-cli
branch
from
16d4603
to
0be7ce4
Compare
catbro666
force-pushed
the
drop-luasocket-in-cli
branch
4 times, most recently
from
81a305f
to
86c374c
Compare
catbro666
force-pushed
the
drop-luasocket-in-cli
branch
from
86c374c
to
a0c77ac
Compare
This is the follow-up PR of #11127 Changing the socket type from luasocket to openresty cosocket causes some test fail weirdly. After investigating, it's mainly because the cosocket support yield and setkeepalive. See the comments in tests. https://konghq.atlassian.net/browse/FTI-4937
catbro666
force-pushed
the
drop-luasocket-in-cli
branch
from
a0c77ac
to
e9a7309
Compare
|
@fffonion please give this one another pass |
fffonion
approved these changes
Aug 11, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow-up PR of #11127
Changing the socket type from luasocket to openresty cosocket causes some test fail weirdly. After investigating, it's mainly because the cosocket support yield and setkeepalive. See the comments in tests.
https://konghq.atlassian.net/browse/FTI-4937