-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): propagate gcp trace header in tracing plugins #11254
Conversation
@hanshuebner 👋 I saw you gave a review on a similar PR for propagating AWS' xray trace headers, would you mind taking a look here as well? Sorry for the ping, this has been sitting around a little while and I'd love to have this included in Kong if possible 🙏 |
@samugi Can you have a look? This seems to be right up your alley. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution!
I gave this a first pass, I'll be looking into the tests next but I have already left some comments that might suggest at least one missing test case.
75bc1d2
to
0a6a9f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, with these tiny changes it should be ready!
Co-Authored-By: Samuele <samuele8@gmail.com>
@jonabc That is correct. I don't have a date to share yet but I expect 3.5.0 to be out roughly in 2-3 months considering 3.4.0 was just released. Again thanks so much for your contribution! |
Is this in EE? |
It is now @outsinre |
Summary
This change parses and propagates the
X-Trace-Context
header that Google provides for calls in Google Cloud Projects (GCP). Google recommends using the OpenTelemetry tracing standard when instrumenting applications, and this provides handling of the header at the API gateway layer 👍Checklist
Full changelog
The field
header_type
now accepts the valuegcp
to propagate theGoogle Cloud trace header
Issue reference
I didn't see an open issue for this, but I'm happy to open an issue and link it here if wanted.