fix(wasm): validate filters in all persistence modes #11288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/proxy
core/clustering
core/db
schema-change-noteworthy
labels
flrgh
force-pushed
the
fix/wasm-dbless-validation
branch
4 times, most recently
from
b2fb848 to
2dde6a1
Compare
flrgh
force-pushed
the
fix/wasm-dbless-validation
branch
from
2dde6a1 to
7ba92da
Compare
hishamhm
reviewed
Jul 27, 2023
flrgh
force-pushed
the
fix/wasm-dbless-validation
branch
from
7ba92da to
0789fcb
Compare
flrgh
force-pushed
the
fix/wasm-dbless-validation
branch
2 times, most recently
from
953e7b7 to
9a6b04f
Compare
|
|
flrgh
force-pushed
the
fix/wasm-dbless-validation
branch
from
4aa1ebb to
807d91f
Compare
flrgh
force-pushed
the
fix/wasm-dbless-validation
branch
from
807d91f to
eb0aff4
Compare
zhongweiy
reviewed
Jul 28, 2023
zhongweiy
approved these changes
Jul 28, 2023
team-gateway-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
The primary purpose of this change is to ensure that each .filters[].name is validated against available/installed filters in dbless mode (this was only working in db mode prior). I also added an additional entity check which will return a more descriptive error when wasm is disabled or no filters are present (this is more useful for dbless mode than anything). (cherry picked from commit 33dbd4f)
flrgh
added a commit
that referenced
this pull request
Jul 28, 2023
The primary purpose of this change is to ensure that each .filters[].name is validated against available/installed filters in dbless mode (this was only working in db mode prior). I also added an additional entity check which will return a more descriptive error when wasm is disabled or no filters are present (this is more useful for dbless mode than anything). (cherry picked from commit 33dbd4f) Co-authored-by: Michael Martin <flrgh@protonmail.com>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The primary purpose of this change is to ensure that each
.filters[].nameis validated against available/installed filters in dbless mode (this was only working in db mode prior).I also added an additional entity check which will return a more descriptive error when wasm is disabled or no filters are present (this is more useful for dbless mode than anything).
Checklist
[ ] There's an entry in the CHANGELOG[ ] There is a user-facing docs PRIssue reference
KAG-2059