Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(dbless): fix flaky test #11292

Merged
merged 1 commit into from
Jul 27, 2023
Merged

tests(dbless): fix flaky test #11292

merged 1 commit into from
Jul 27, 2023

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Jul 26, 2023 •
edited by jira bot
Loading

Summary

Fix two flaky tests.

Checklist

Full changelog

N/A

Issue reference

KAG-2158, KAG-2077

@ADD-SP ADD-SP marked this pull request as ready for review July 26, 2023 06:13
@ADD-SP ADD-SP added the pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes) label Jul 26, 2023
flrgh
flrgh requested changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@flrgh flrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the usage of assert.eventually(), and this should be good to go.

@ADD-SP ADD-SP force-pushed the add_sp/tests-fix-flaky-dbless-tests branch from 8623837 to 491817a Compare July 27, 2023 04:49
@ADD-SP ADD-SP requested a review from flrgh July 27, 2023 04:49
@ADD-SP ADD-SP removed the pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes) label Jul 27, 2023
@ADD-SP ADD-SP force-pushed the add_sp/tests-fix-flaky-dbless-tests branch from 491817a to d8bb7fa Compare July 27, 2023 05:09
@flrgh flrgh merged commit 91dcd61 into master Jul 27, 2023
@flrgh flrgh deleted the add_sp/tests-fix-flaky-dbless-tests branch July 27, 2023 17:02
@team-gateway-bot team-gateway-bot mentioned this pull request Jul 27, 2023
Merged
team-gateway-bot pushed a commit that referenced this pull request Jul 27, 2023
@ADD-SP @github-actions
tests(dbless): fix flaky test (#11292)
2e9b1e8 
(cherry picked from commit 91dcd61)
flrgh pushed a commit that referenced this pull request Jul 27, 2023
@team-gateway-bot @ADD-SP
tests(dbless): fix flaky test (#11292)
baeb44b 
(cherry picked from commit 91dcd61)

Co-authored-by: Qi <add_sp@outlook.com>
@kikito kikito mentioned this pull request Aug 9, 2023
Merged
@kikito kikito mentioned this pull request Oct 3, 2023
Merged
@kikito kikito mentioned this pull request Jan 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@oowl oowl oowl approved these changes

@flrgh flrgh flrgh approved these changes

Assignees

@ADD-SP ADD-SP

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ADD-SP @flrgh @oowl @StarlightIbuki