-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): re-use cache key from build workflow #11299
Conversation
a2f10b9
to
0286e5e
Compare
48809a6
to
338bfc0
Compare
338bfc0
to
cadcb37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
8dc1e0c
to
cbab956
Compare
cbab956
to
7129e52
Compare
I've also updated |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.4.x release/3.4.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.4.x
# Create a new branch
git switch --create backport-11299-to-release/3.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 68b7b6f9cb9eb52af0ed558b2952a3239926b5b7
# Push it to GitHub
git push --set-upstream origin backport-11299-to-release/3.4.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.4.x Then, create a pull request where the |
This makes build cache key generation reusable across different workflows. The test and release workflows now use the same "recipe" for cache key generation--no more copy/paste.
This makes build cache key generation reusable across different workflows. The test and release workflows now use the same "recipe" for cache key generation--no more copy/paste.
${{ hashFiles('build/**') }} | ||
${{ hashFiles('kong-*.rockspec') }} | ||
${{ hashFiles('kong.conf.default') }} | ||
${{ hashFiles('kong/**') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be set for non-release workflows (build_and_test, perf), because almost every PR change lua codes and cause a cache miss (unless the PR only changes tests, which is a less common case).
This updates the `build-cache-key` action to accept additional paths to use when generating the cache key. The impetus for this change is to allow removal of `kong/**` from the default cache key so that it can be used selectively. See also: #11299 (comment)
This makes build cache key generation reusable across different workflows. The test and release workflows now use the same "recipe" for cache key generation--no more copy/paste.