Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): support http queries in expression #11348

Merged
merged 39 commits into from
Aug 10, 2023
Merged

feat(router): support http queries in expression #11348

merged 39 commits into from
Aug 10, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Aug 3, 2023 •
edited
Loading

Summary

This PR will replace #11072.
I will add change log entry after 3.4 release.

KAG-2050
KAG-2289

Checklist

Full changelog

  • add new schema field http.queries.*
  • add queries_key for cache
  • use param lua_max_uri_args
  • check unknown field in select()

Issue reference

Fix #[issue number]

@chronolaw chronolaw mentioned this pull request Aug 3, 2023
Closed
3 tasks
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 3, 2023
@chronolaw chronolaw force-pushed the feat/support_http_query_in_expression branch 3 times, most recently from c03f0a6 to 15d3d3c Compare August 3, 2023 12:02
@chronolaw chronolaw marked this pull request as ready for review August 4, 2023 02:01
@chronolaw chronolaw requested a review from dndx August 4, 2023 03:17
chronolaw
chronolaw commented Aug 4, 2023
View reviewed changes
kong/router/atc.lua Outdated Show resolved Hide resolved
dndx
dndx reviewed Aug 8, 2023
View reviewed changes
kong/router/atc.lua Outdated Show resolved Hide resolved
kong/router/atc.lua Outdated Show resolved Hide resolved
@kikito kikito marked this pull request as draft August 8, 2023 08:24
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Aug 8, 2023
@chronolaw chronolaw marked this pull request as ready for review August 8, 2023 11:47
@chronolaw chronolaw force-pushed the feat/support_http_query_in_expression branch 3 times, most recently from 6f68873 to 95fbbf9 Compare August 9, 2023 01:28
dndx
dndx reviewed Aug 9, 2023
View reviewed changes
kong/router/atc.lua Outdated Show resolved Hide resolved
dndx
dndx reviewed Aug 9, 2023
View reviewed changes
kong/router/atc.lua Outdated Show resolved Hide resolved
kong/router/atc.lua Outdated Show resolved Hide resolved
kong/router/atc.lua Outdated Show resolved Hide resolved
kong/router/atc.lua Show resolved Hide resolved
kong/router/atc.lua Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Aug 9, 2023
dndx
dndx reviewed Aug 9, 2023
View reviewed changes
kong/router/atc.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw force-pushed the feat/support_http_query_in_expression branch from 019fc03 to a9a0e40 Compare August 10, 2023 06:31
dndx
dndx reviewed Aug 10, 2023
View reviewed changes
kong/router/atc.lua Outdated Show resolved Hide resolved
@dndx dndx merged commit 94a025d into master Aug 10, 2023
@dndx dndx deleted the feat/support_http_query_in_expression branch August 10, 2023 07:49
@randmonkey randmonkey mentioned this pull request Aug 16, 2023
Closed
1 task
chronolaw added a commit that referenced this pull request Aug 24, 2023
@chronolaw
pr #11348
6010b64
@team-gateway-bot team-gateway-bot mentioned this pull request Aug 28, 2023
Merged
team-gateway-bot pushed a commit that referenced this pull request Aug 28, 2023
@chronolaw @github-actions
feat(router): support HTTP query parameters in expression routes (#11348
4a753f3 
)

(cherry picked from commit 94a025d)
dndx pushed a commit that referenced this pull request Aug 31, 2023
@chronolaw @dndx
feat(router): support HTTP query parameters in expression routes (#11348
a225cd1 
)

(cherry picked from commit 94a025d)
@chronolaw chronolaw mentioned this pull request Sep 25, 2023
Merged
windmgc added a commit that referenced this pull request Sep 26, 2023
@windmgc
Add new changelog for #11348
5f4f1e7
windmgc added a commit that referenced this pull request Sep 26, 2023
@vm-001 @windmgc
docs(changelog): generate 3.4.1 changelog (#11640)
359cd0a 
* docs(*): generate 3.4.1 changelog

* move legacy changelog entries to CHANGELOG.md

* Add new changelog for #11348

---------

Co-authored-by: windmgc <windmgc@gmail.com>
@acgoldsmith acgoldsmith mentioned this pull request Sep 27, 2023
Merged
2 tasks
@chronolaw chronolaw mentioned this pull request Sep 29, 2023
Merged
2 tasks
@kikito kikito mentioned this pull request Oct 3, 2023
Merged
@nowNick nowNick mentioned this pull request Oct 23, 2023
Closed
1 task
@kikito kikito mentioned this pull request Jan 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randmonkey randmonkey randmonkey left review comments

@dndx dndx dndx approved these changes

Assignees

@chronolaw chronolaw

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chronolaw @dndx @randmonkey