Fix(language): Critical messages during startup #11372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarlightIbuki
force-pushed
the
fix/pdk-sock-crit-log
branch
from
2bf9b7d
to
f433309
Compare
We used to check if the plugin server socket is ready by trying to connect, which will generate a lot of critical messages which cannot be suppressed due to OpenResty's limitation. As the logic is not really helpful, we decided to revert it. Revert "fix(pluginserver): error if req come before ready (#9507)" This reverts commit e7b6963. Fix KAG-2136 Fix #11084 Fix Kong/kong-js-pdk#308
StarlightIbuki
force-pushed
the
fix/pdk-sock-crit-log
branch
from
f433309
to
c92bea6
Compare
fffonion
approved these changes
Aug 10, 2023
chronolaw
reviewed
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We used to check if the plugin server socket is ready by trying to connect, which will generate a lot of critical messages which cannot be suppressed due to OpenResty's limitation. As the feature is not really helpful, we decided to revert it.
Revert "fix(pluginserver): error if req come before ready (#9507)"
This reverts commit e7b6963.
Checklist
Issue reference
Fix KAG-2136
Fix #11084
Fix Kong/kong-js-pdk#308