Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dns): fix retry and timeout handling #11386

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix(dns): fix retry and timeout handling #11386

merged 1 commit into from
Aug 11, 2023

Conversation

hanshuebner
Copy link
Contributor

@hanshuebner hanshuebner commented Aug 10, 2023 •
edited
Loading

Summary

  • Stop retrying in dns/client.lua, let the resolver handle this. This change also makes it possible to disable retries, which previously was not possible
  • Be more faithful to the timeouts set by the user. Previously, the timeout configured was used only for the ultimate request sent to the DNS server, but asynchronous requests allowed longer timeouts which was not transparent.
  • When the DNS server fails, stop trying other query types. Previously, the behavior was such that after an (intermediate) failure to query for one record type (say "SRV"), the client would try the next record type (say "A") and succeed with that. It would then return the contents of the "A" record even if the "SRV" record pointed to a different address.
  • Change domain names used for testing the DNS client into the kong-gateway-testing.link zone, which is controlled by the Kong Gateway team.

Checklist

Issue reference

Fixes #10182
KAG-2300

@bungle bungle requested a review from Tieske August 10, 2023 14:04
@hanshuebner hanshuebner force-pushed the fix/kag-2300-dns-retries-and-timeouts branch 3 times, most recently from 19aa639 to fc050c9 Compare August 11, 2023 05:14
@hanshuebner hanshuebner force-pushed the fix/kag-2300-dns-retries-and-timeouts branch from fc050c9 to c0db5d2 Compare August 11, 2023 05:41
@hanshuebner hanshuebner marked this pull request as ready for review August 11, 2023 06:31
@hanshuebner hanshuebner force-pushed the fix/kag-2300-dns-retries-and-timeouts branch from c0db5d2 to 931b3c2 Compare August 11, 2023 06:35
samugi
samugi requested changes Aug 11, 2023
View reviewed changes
Copy link
Member

@samugi samugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple of comments

@hanshuebner
fix(dns): fix retry and timeout handling
b5662d9 
 - Stop retrying in dns/client.lua, let the resolver handle this.  This
   change also makes it possible to disable retries, which previously
   was not possible
 - Be more faithful to the timeouts set by the user.  Previously, the
   timeout configured was used only for the ultimate request sent to
   the DNS server, but asynchronous requests allowed longer timeouts
   which was not transparent.
 - When the DNS server fails, stop trying other query types.  Previously,
   the behavior was such that after an (intermediate) failure to query
   for one record type (say "SRV"), the client would try the next record
   type (say "A") and succeed with that.  It would then return the
   contents of the "A" record even if the "SRV" record pointed to a
   different address.
 - Change domain names used for testing the DNS client into the
   kong-gateway-testing.link zone, which is controlled by the Kong Gateway
   team.

#10182
KAG-2300
@hanshuebner hanshuebner force-pushed the fix/kag-2300-dns-retries-and-timeouts branch from 931b3c2 to b5662d9 Compare August 11, 2023 09:58
@hanshuebner hanshuebner merged commit 9294874 into master Aug 11, 2023
21 checks passed
@hanshuebner hanshuebner deleted the fix/kag-2300-dns-retries-and-timeouts branch August 11, 2023 14:41
@chobits chobits mentioned this pull request Nov 16, 2023
Merged
3 tasks
chobits pushed a commit that referenced this pull request Nov 16, 2023
@hanshuebner @chobits
fix(dns): fix retry and timeout handling (#11386)
4c7b011 
- Stop retrying in dns/client.lua, let the resolver handle this.  This
   change also makes it possible to disable retries, which previously
   was not possible
 - Be more faithful to the timeouts set by the user.  Previously, the
   timeout configured was used only for the ultimate request sent to
   the DNS server, but asynchronous requests allowed longer timeouts
   which was not transparent.
 - When the DNS server fails, stop trying other query types.  Previously,
   the behavior was such that after an (intermediate) failure to query
   for one record type (say "SRV"), the client would try the next record
   type (say "A") and succeed with that.  It would then return the
   contents of the "A" record even if the "SRV" record pointed to a
   different address.
 - Change domain names used for testing the DNS client into the
   kong-gateway-testing.link zone, which is controlled by the Kong Gateway
   team.

Fixes #10182
KAG-2300
chobits pushed a commit that referenced this pull request Nov 16, 2023
@hanshuebner @chobits
fix(dns): fix retry and timeout handling (#11386)
4c80884 
- Stop retrying in dns/client.lua, let the resolver handle this.  This
   change also makes it possible to disable retries, which previously
   was not possible
 - Be more faithful to the timeouts set by the user.  Previously, the
   timeout configured was used only for the ultimate request sent to
   the DNS server, but asynchronous requests allowed longer timeouts
   which was not transparent.
 - When the DNS server fails, stop trying other query types.  Previously,
   the behavior was such that after an (intermediate) failure to query
   for one record type (say "SRV"), the client would try the next record
   type (say "A") and succeed with that.  It would then return the
   contents of the "A" record even if the "SRV" record pointed to a
   different address.
 - Change domain names used for testing the DNS client into the
   kong-gateway-testing.link zone, which is controlled by the Kong Gateway
   team.

Fixes #10182
KAG-2300

Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com>
This was referenced Nov 16, 2023
Closed
Merged
bungle pushed a commit that referenced this pull request Nov 16, 2023
@hanshuebner @bungle
fix(dns): fix retry and timeout handling (#11386)
1ab8980 
- Stop retrying in dns/client.lua, let the resolver handle this.  This
   change also makes it possible to disable retries, which previously
   was not possible
 - Be more faithful to the timeouts set by the user.  Previously, the
   timeout configured was used only for the ultimate request sent to
   the DNS server, but asynchronous requests allowed longer timeouts
   which was not transparent.
 - When the DNS server fails, stop trying other query types.  Previously,
   the behavior was such that after an (intermediate) failure to query
   for one record type (say "SRV"), the client would try the next record
   type (say "A") and succeed with that.  It would then return the
   contents of the "A" record even if the "SRV" record pointed to a
   different address.
 - Change domain names used for testing the DNS client into the
   kong-gateway-testing.link zone, which is controlled by the Kong Gateway
   team.

Fixes #10182
KAG-2300
dndx pushed a commit that referenced this pull request Nov 24, 2023
@hanshuebner @dndx
fix(dns): fix retry and timeout handling (#11386)
7315817 
- Stop retrying in dns/client.lua, let the resolver handle this.  This
   change also makes it possible to disable retries, which previously
   was not possible
 - Be more faithful to the timeouts set by the user.  Previously, the
   timeout configured was used only for the ultimate request sent to
   the DNS server, but asynchronous requests allowed longer timeouts
   which was not transparent.
 - When the DNS server fails, stop trying other query types.  Previously,
   the behavior was such that after an (intermediate) failure to query
   for one record type (say "SRV"), the client would try the next record
   type (say "A") and succeed with that.  It would then return the
   contents of the "A" record even if the "SRV" record pointed to a
   different address.
 - Change domain names used for testing the DNS client into the
   kong-gateway-testing.link zone, which is controlled by the Kong Gateway
   team.

Fixes #10182
KAG-2300

Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com>
@chobits chobits mentioned this pull request Nov 28, 2023
Merged
@chobits chobits mentioned this pull request Nov 28, 2023
Merged
chobits pushed a commit that referenced this pull request Nov 29, 2023
@hanshuebner @chobits
fix(dns): fix retry and timeout handling (#11386)
e137d99 
- Stop retrying in dns/client.lua, let the resolver handle this.  This
   change also makes it possible to disable retries, which previously
   was not possible
 - Be more faithful to the timeouts set by the user.  Previously, the
   timeout configured was used only for the ultimate request sent to
   the DNS server, but asynchronous requests allowed longer timeouts
   which was not transparent.
 - When the DNS server fails, stop trying other query types.  Previously,
   the behavior was such that after an (intermediate) failure to query
   for one record type (say "SRV"), the client would try the next record
   type (say "A") and succeed with that.  It would then return the
   contents of the "A" record even if the "SRV" record pointed to a
   different address.
 - Change domain names used for testing the DNS client into the
   kong-gateway-testing.link zone, which is controlled by the Kong Gateway
   team.

Fixes #10182
KAG-2300
dndx pushed a commit that referenced this pull request Nov 29, 2023
@hanshuebner @dndx
fix(dns): fix retry and timeout handling (#11386)
d4c7109 
- Stop retrying in dns/client.lua, let the resolver handle this.  This
   change also makes it possible to disable retries, which previously
   was not possible
 - Be more faithful to the timeouts set by the user.  Previously, the
   timeout configured was used only for the ultimate request sent to
   the DNS server, but asynchronous requests allowed longer timeouts
   which was not transparent.
 - When the DNS server fails, stop trying other query types.  Previously,
   the behavior was such that after an (intermediate) failure to query
   for one record type (say "SRV"), the client would try the next record
   type (say "A") and succeed with that.  It would then return the
   contents of the "A" record even if the "SRV" record pointed to a
   different address.
 - Change domain names used for testing the DNS client into the
   kong-gateway-testing.link zone, which is controlled by the Kong Gateway
   team.

Fixes #10182
KAG-2300
chobits pushed a commit that referenced this pull request Nov 30, 2023
@hanshuebner @chobits
fix(dns): fix retry and timeout handling (#11386)
81fc4aa 
- Stop retrying in dns/client.lua, let the resolver handle this.  This
   change also makes it possible to disable retries, which previously
   was not possible
 - Be more faithful to the timeouts set by the user.  Previously, the
   timeout configured was used only for the ultimate request sent to
   the DNS server, but asynchronous requests allowed longer timeouts
   which was not transparent.
 - When the DNS server fails, stop trying other query types.  Previously,
   the behavior was such that after an (intermediate) failure to query
   for one record type (say "SRV"), the client would try the next record
   type (say "A") and succeed with that.  It would then return the
   contents of the "A" record even if the "SRV" record pointed to a
   different address.
 - Change domain names used for testing the DNS client into the
   kong-gateway-testing.link zone, which is controlled by the Kong Gateway
   team.

Fixes #10182
KAG-2300
dndx pushed a commit that referenced this pull request Nov 30, 2023
@hanshuebner @dndx
fix(dns): fix retry and timeout handling (#11386)
e5fde8c 
- Stop retrying in dns/client.lua, let the resolver handle this.  This
   change also makes it possible to disable retries, which previously
   was not possible
 - Be more faithful to the timeouts set by the user.  Previously, the
   timeout configured was used only for the ultimate request sent to
   the DNS server, but asynchronous requests allowed longer timeouts
   which was not transparent.
 - When the DNS server fails, stop trying other query types.  Previously,
   the behavior was such that after an (intermediate) failure to query
   for one record type (say "SRV"), the client would try the next record
   type (say "A") and succeed with that.  It would then return the
   contents of the "A" record even if the "SRV" record pointed to a
   different address.
 - Change domain names used for testing the DNS client into the
   kong-gateway-testing.link zone, which is controlled by the Kong Gateway
   team.

Fixes #10182
KAG-2300
chobits pushed a commit that referenced this pull request Nov 30, 2023
@hanshuebner @chobits
fix(dns): fix retry and timeout handling (#11386)
737b983 
- Stop retrying in dns/client.lua, let the resolver handle this.  This
   change also makes it possible to disable retries, which previously
   was not possible
 - Be more faithful to the timeouts set by the user.  Previously, the
   timeout configured was used only for the ultimate request sent to
   the DNS server, but asynchronous requests allowed longer timeouts
   which was not transparent.
 - When the DNS server fails, stop trying other query types.  Previously,
   the behavior was such that after an (intermediate) failure to query
   for one record type (say "SRV"), the client would try the next record
   type (say "A") and succeed with that.  It would then return the
   contents of the "A" record even if the "SRV" record pointed to a
   different address.
 - Change domain names used for testing the DNS client into the
   kong-gateway-testing.link zone, which is controlled by the Kong Gateway
   team.

Fixes #10182
KAG-2300
@chobits chobits mentioned this pull request Nov 30, 2023
Closed
@kikito kikito mentioned this pull request Jan 24, 2024
Closed
3 tasks
AndyZhang0707 added a commit that referenced this pull request Jul 18, 2024
@AndyZhang0707
Revert "fix(dns): fix retry and timeout handling (#11386)"
5ac37a4 
This reverts commit 7315817.
AndyZhang0707 added a commit that referenced this pull request Jul 26, 2024
@AndyZhang0707
Revert "fix(dns): fix retry and timeout handling (#11386)"
76f4a85 
This reverts commit 7315817.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samugi samugi samugi approved these changes

@Tieske Tieske Awaiting requested review from Tieske

Assignees

@hanshuebner hanshuebner

Labels
changelog size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS keep retrying different qtypes on hard error(s) from DNS server
2 participants
@hanshuebner @samugi