fix(tracing): record http.status_code when request is not proxied #11406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locao
force-pushed
the
fix/trace_not_proxied_requests
branch
from
b63680f to
8c77928
Compare
|
Thx @locao for driving this one forward! |
gruceo
approved these changes
Aug 15, 2023
locao
force-pushed
the
fix/trace_not_proxied_requests
branch
from
8c77928 to
a512992
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR invokes instrumentation when kong requests are not proxied to the upstream, so that the
relevant span attributes are set on all requests.
Checklist
Full changelog
http.status_codeeven when request is not proxied.Issue reference
Fixes #11141
Closes #11152
KAG-2346