Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(response): fix response status code is not real upstream status when using kong.response function #11437

Merged
merged 4 commits into from
Aug 24, 2023
Merged

fix(response): fix response status code is not real upstream status when using kong.response function #11437

merged 4 commits into from
Aug 24, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Aug 22, 2023 •
edited
Loading

Summary

When kong uses kong_buffered_http and upstream timeout, the return status code needs to return 504 (which return by ngx.location.capture), not 502.

Checklist

Full changelog

Issue reference

FTI-5320

@oowl oowl requested a review from bungle August 22, 2023 11:12
@locao
Copy link
Contributor

locao commented Aug 22, 2023

Could you add a test so we make sure this issue never comes back?

@chronolaw
Copy link
Contributor

Need a change log entry for it.

@oowl oowl changed the title fix(response): fix response status code as not same as real upstream … fix(response): fix response status code as not same as real upstream status when using kong.response function Aug 24, 2023
@oowl oowl changed the title fix(response): fix response status code as not same as real upstream status when using kong.response function fix(response): fix response status code is not real upstream status when using kong.response function Aug 24, 2023
@oowl oowl force-pushed the fix/response_func_status branch from fff08b7 to 358698b Compare August 24, 2023 07:41
@oowl oowl requested a review from chronolaw August 24, 2023 07:43
chronolaw
chronolaw reviewed Aug 24, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@oowl oowl requested a review from chronolaw August 24, 2023 08:25
@fffonion fffonion merged commit 704c72d into master Aug 24, 2023
@fffonion fffonion deleted the fix/response_func_status branch August 24, 2023 08:50
windmgc pushed a commit that referenced this pull request Jan 24, 2024
@oowl @windmgc
fix(core): fix response status code is not real upstream status when …
ed37f2c 
…using kong.response function (#11437)

When kong uses kong_buffered_http and upstream timeout, the return status code needs to return 504 (which return by ngx.location.capture), not 502.

FTI-5320
@windmgc windmgc mentioned this pull request Jan 24, 2024
Merged
3 tasks
windmgc pushed a commit that referenced this pull request Mar 7, 2024
@oowl @windmgc
fix(core): fix response status code is not real upstream status when …
edf3ed6 
…using kong.response function (#11437)

When kong uses kong_buffered_http and upstream timeout, the return status code needs to return 504 (which return by ngx.location.capture), not 502.

FTI-5320
windmgc pushed a commit that referenced this pull request Mar 8, 2024
@oowl @windmgc
fix(core): fix response status code is not real upstream status when …
7095210 
…using kong.response function (#11437)

When kong uses kong_buffered_http and upstream timeout, the return status code needs to return 504 (which return by ngx.location.capture), not 502.

FTI-5320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

@chronolaw chronolaw chronolaw approved these changes

@bungle bungle Awaiting requested review from bungle

Assignees

@oowl oowl

Labels
changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oowl @locao @chronolaw @fffonion